dataStore.go 56 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979980981982983984985986987988989990991992993994995996997998999100010011002100310041005100610071008100910101011101210131014101510161017101810191020102110221023102410251026102710281029103010311032103310341035103610371038103910401041104210431044104510461047104810491050105110521053105410551056105710581059106010611062106310641065106610671068106910701071107210731074107510761077107810791080108110821083108410851086108710881089109010911092109310941095109610971098109911001101110211031104110511061107110811091110111111121113111411151116111711181119112011211122112311241125112611271128112911301131113211331134113511361137113811391140114111421143114411451146114711481149115011511152115311541155115611571158115911601161116211631164116511661167116811691170117111721173117411751176117711781179118011811182118311841185118611871188118911901191119211931194119511961197119811991200120112021203120412051206120712081209121012111212121312141215121612171218121912201221122212231224122512261227122812291230123112321233123412351236123712381239124012411242124312441245124612471248124912501251125212531254125512561257125812591260126112621263126412651266126712681269127012711272127312741275127612771278127912801281128212831284128512861287128812891290129112921293129412951296129712981299130013011302130313041305130613071308130913101311131213131314131513161317131813191320132113221323132413251326132713281329133013311332133313341335133613371338133913401341134213431344134513461347134813491350135113521353135413551356135713581359136013611362136313641365136613671368136913701371137213731374137513761377137813791380138113821383138413851386138713881389139013911392139313941395139613971398139914001401140214031404140514061407140814091410141114121413141414151416141714181419142014211422142314241425142614271428142914301431143214331434143514361437143814391440144114421443144414451446144714481449145014511452145314541455145614571458145914601461146214631464146514661467146814691470147114721473147414751476147714781479148014811482148314841485148614871488148914901491149214931494149514961497149814991500150115021503150415051506150715081509151015111512151315141515151615171518151915201521152215231524152515261527152815291530153115321533153415351536153715381539154015411542154315441545154615471548154915501551155215531554155515561557155815591560156115621563156415651566156715681569157015711572157315741575157615771578157915801581158215831584158515861587158815891590159115921593159415951596159715981599160016011602160316041605160616071608160916101611161216131614161516161617161816191620162116221623162416251626162716281629163016311632163316341635163616371638163916401641164216431644164516461647164816491650165116521653165416551656165716581659166016611662166316641665166616671668166916701671167216731674167516761677167816791680168116821683168416851686168716881689169016911692169316941695169616971698169917001701170217031704170517061707170817091710171117121713171417151716171717181719172017211722172317241725172617271728172917301731173217331734173517361737173817391740174117421743174417451746174717481749175017511752175317541755175617571758175917601761176217631764176517661767176817691770177117721773177417751776177717781779178017811782178317841785178617871788178917901791179217931794179517961797179817991800180118021803180418051806180718081809181018111812181318141815181618171818181918201821182218231824182518261827182818291830183118321833183418351836183718381839184018411842184318441845184618471848184918501851185218531854185518561857185818591860186118621863186418651866186718681869187018711872187318741875187618771878187918801881188218831884188518861887188818891890189118921893189418951896189718981899190019011902190319041905190619071908190919101911191219131914191519161917191819191920192119221923192419251926192719281929193019311932193319341935193619371938193919401941194219431944194519461947194819491950195119521953195419551956195719581959196019611962196319641965196619671968196919701971197219731974197519761977197819791980198119821983198419851986198719881989199019911992199319941995199619971998199920002001200220032004200520062007200820092010201120122013201420152016201720182019202020212022202320242025202620272028202920302031203220332034203520362037203820392040204120422043204420452046204720482049
  1. /*
  2. * Copyright (c) 2015, Psiphon Inc.
  3. * All rights reserved.
  4. *
  5. * This program is free software: you can redistribute it and/or modify
  6. * it under the terms of the GNU General Public License as published by
  7. * the Free Software Foundation, either version 3 of the License, or
  8. * (at your option) any later version.
  9. *
  10. * This program is distributed in the hope that it will be useful,
  11. * but WITHOUT ANY WARRANTY; without even the implied warranty of
  12. * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
  13. * GNU General Public License for more details.
  14. *
  15. * You should have received a copy of the GNU General Public License
  16. * along with this program. If not, see <http://www.gnu.org/licenses/>.
  17. *
  18. */
  19. package psiphon
  20. import (
  21. "bytes"
  22. "encoding/json"
  23. "math"
  24. "sync"
  25. "time"
  26. "github.com/Psiphon-Labs/psiphon-tunnel-core/psiphon/common"
  27. "github.com/Psiphon-Labs/psiphon-tunnel-core/psiphon/common/errors"
  28. "github.com/Psiphon-Labs/psiphon-tunnel-core/psiphon/common/parameters"
  29. "github.com/Psiphon-Labs/psiphon-tunnel-core/psiphon/common/prng"
  30. "github.com/Psiphon-Labs/psiphon-tunnel-core/psiphon/common/protocol"
  31. )
  32. var (
  33. datastoreServerEntriesBucket = []byte("serverEntries")
  34. datastoreServerEntryTagsBucket = []byte("serverEntryTags")
  35. datastoreServerEntryTombstoneTagsBucket = []byte("serverEntryTombstoneTags")
  36. datastoreSplitTunnelRouteETagsBucket = []byte("splitTunnelRouteETags")
  37. datastoreSplitTunnelRouteDataBucket = []byte("splitTunnelRouteData")
  38. datastoreUrlETagsBucket = []byte("urlETags")
  39. datastoreKeyValueBucket = []byte("keyValues")
  40. datastoreRemoteServerListStatsBucket = []byte("remoteServerListStats")
  41. datastoreFailedTunnelStatsBucket = []byte("failedTunnelStats")
  42. datastoreSLOKsBucket = []byte("SLOKs")
  43. datastoreTacticsBucket = []byte("tactics")
  44. datastoreSpeedTestSamplesBucket = []byte("speedTestSamples")
  45. datastoreDialParametersBucket = []byte("dialParameters")
  46. datastoreLastConnectedKey = "lastConnected"
  47. datastoreLastServerEntryFilterKey = []byte("lastServerEntryFilter")
  48. datastoreAffinityServerEntryIDKey = []byte("affinityServerEntryID")
  49. datastorePersistentStatTypeRemoteServerList = string(datastoreRemoteServerListStatsBucket)
  50. datastorePersistentStatTypeFailedTunnel = string(datastoreFailedTunnelStatsBucket)
  51. datastoreServerEntryFetchGCThreshold = 10
  52. datastoreMutex sync.RWMutex
  53. datastoreReferenceCount int64
  54. activeDatastoreDB *datastoreDB
  55. )
  56. // OpenDataStore opens and initializes the singleton datastore instance.
  57. //
  58. // Nested Open/CloseDataStore calls are supported: OpenDataStore will succeed
  59. // when called when the datastore is initialized. Every call to OpenDataStore
  60. // must be paired with a corresponding call to CloseDataStore to ensure the
  61. // datastore is closed.
  62. func OpenDataStore(config *Config) error {
  63. datastoreMutex.Lock()
  64. if datastoreReferenceCount < 0 || datastoreReferenceCount == math.MaxInt64 {
  65. datastoreMutex.Unlock()
  66. return errors.Tracef(
  67. "invalid datastore reference count: %d", datastoreReferenceCount)
  68. }
  69. datastoreReferenceCount += 1
  70. if datastoreReferenceCount > 1 {
  71. var err error
  72. if activeDatastoreDB == nil {
  73. err = errors.TraceNew("datastore unexpectedly closed")
  74. }
  75. datastoreMutex.Unlock()
  76. return err
  77. }
  78. existingDB := activeDatastoreDB
  79. if existingDB != nil {
  80. datastoreMutex.Unlock()
  81. return errors.TraceNew("datastore unexpectedly open")
  82. }
  83. newDB, err := datastoreOpenDB(config.GetDataStoreDirectory())
  84. if err != nil {
  85. datastoreMutex.Unlock()
  86. return errors.Trace(err)
  87. }
  88. activeDatastoreDB = newDB
  89. datastoreMutex.Unlock()
  90. _ = resetAllPersistentStatsToUnreported()
  91. return nil
  92. }
  93. // CloseDataStore closes the singleton datastore instance, if open.
  94. func CloseDataStore() {
  95. datastoreMutex.Lock()
  96. defer datastoreMutex.Unlock()
  97. if datastoreReferenceCount <= 0 {
  98. NoticeWarning(
  99. "invalid datastore reference count: %d", datastoreReferenceCount)
  100. return
  101. }
  102. datastoreReferenceCount -= 1
  103. if datastoreReferenceCount > 0 {
  104. return
  105. }
  106. if activeDatastoreDB == nil {
  107. return
  108. }
  109. err := activeDatastoreDB.close()
  110. if err != nil {
  111. NoticeWarning("failed to close datastore: %s", errors.Trace(err))
  112. }
  113. activeDatastoreDB = nil
  114. }
  115. // datastoreView runs a read-only transaction, making datastore buckets and
  116. // values available to the supplied function.
  117. //
  118. // Bucket value slices are only valid for the duration of the transaction and
  119. // _must_ not be referenced directly outside the transaction.
  120. func datastoreView(fn func(tx *datastoreTx) error) error {
  121. datastoreMutex.RLock()
  122. defer datastoreMutex.RUnlock()
  123. if activeDatastoreDB == nil {
  124. return errors.TraceNew("datastore not open")
  125. }
  126. err := activeDatastoreDB.view(fn)
  127. if err != nil {
  128. err = errors.Trace(err)
  129. }
  130. return err
  131. }
  132. // datastoreUpdate runs a read-write transaction, making datastore buckets and
  133. // values available to the supplied function.
  134. //
  135. // Bucket value slices are only valid for the duration of the transaction and
  136. // _must_ not be referenced directly outside the transaction.
  137. func datastoreUpdate(fn func(tx *datastoreTx) error) error {
  138. datastoreMutex.RLock()
  139. defer datastoreMutex.RUnlock()
  140. if activeDatastoreDB == nil {
  141. return errors.TraceNew("database not open")
  142. }
  143. err := activeDatastoreDB.update(fn)
  144. if err != nil {
  145. err = errors.Trace(err)
  146. }
  147. return err
  148. }
  149. // StoreServerEntry adds the server entry to the datastore.
  150. //
  151. // When a server entry already exists for a given server, it will be
  152. // replaced only if replaceIfExists is set or if the the ConfigurationVersion
  153. // field of the new entry is strictly higher than the existing entry.
  154. //
  155. // If the server entry data is malformed, an alert notice is issued and
  156. // the entry is skipped; no error is returned.
  157. func StoreServerEntry(serverEntryFields protocol.ServerEntryFields, replaceIfExists bool) error {
  158. // TODO: call serverEntryFields.VerifySignature. At this time, we do not do
  159. // this as not all server entries have an individual signature field. All
  160. // StoreServerEntry callers either call VerifySignature or obtain server
  161. // entries from a trusted source (embedded in a signed client, or in a signed
  162. // authenticated package).
  163. // Server entries should already be validated before this point,
  164. // so instead of skipping we fail with an error.
  165. err := protocol.ValidateServerEntryFields(serverEntryFields)
  166. if err != nil {
  167. return errors.Tracef("invalid server entry: %s", err)
  168. }
  169. // BoltDB implementation note:
  170. // For simplicity, we don't maintain indexes on server entry
  171. // region or supported protocols. Instead, we perform full-bucket
  172. // scans with a filter. With a small enough database (thousands or
  173. // even tens of thousand of server entries) and common enough
  174. // values (e.g., many servers support all protocols), performance
  175. // is expected to be acceptable.
  176. err = datastoreUpdate(func(tx *datastoreTx) error {
  177. serverEntries := tx.bucket(datastoreServerEntriesBucket)
  178. serverEntryTags := tx.bucket(datastoreServerEntryTagsBucket)
  179. serverEntryTombstoneTags := tx.bucket(datastoreServerEntryTombstoneTagsBucket)
  180. serverEntryID := []byte(serverEntryFields.GetIPAddress())
  181. // Check not only that the entry exists, but is valid. This
  182. // will replace in the rare case where the data is corrupt.
  183. existingConfigurationVersion := -1
  184. existingData := serverEntries.get(serverEntryID)
  185. if existingData != nil {
  186. var existingServerEntry *protocol.ServerEntry
  187. err := json.Unmarshal(existingData, &existingServerEntry)
  188. if err == nil {
  189. existingConfigurationVersion = existingServerEntry.ConfigurationVersion
  190. }
  191. }
  192. exists := existingConfigurationVersion > -1
  193. newer := exists && existingConfigurationVersion < serverEntryFields.GetConfigurationVersion()
  194. update := !exists || replaceIfExists || newer
  195. if !update {
  196. return nil
  197. }
  198. serverEntryTag := serverEntryFields.GetTag()
  199. // Generate a derived tag when the server entry has no tag.
  200. if serverEntryTag == "" {
  201. serverEntryTag = protocol.GenerateServerEntryTag(
  202. serverEntryFields.GetIPAddress(),
  203. serverEntryFields.GetWebServerSecret())
  204. serverEntryFields.SetTag(serverEntryTag)
  205. }
  206. serverEntryTagBytes := []byte(serverEntryTag)
  207. // Ignore the server entry if it was previously pruned and a tombstone is
  208. // set.
  209. //
  210. // This logic is enforced only for embedded server entries, as all other
  211. // sources are considered to be definitive and non-stale. These exceptions
  212. // intentionally allow the scenario where a server is temporarily deleted
  213. // and then restored; in this case, it's desired for pruned server entries
  214. // to be restored.
  215. if serverEntryFields.GetLocalSource() == protocol.SERVER_ENTRY_SOURCE_EMBEDDED {
  216. if serverEntryTombstoneTags.get(serverEntryTagBytes) != nil {
  217. return nil
  218. }
  219. }
  220. data, err := json.Marshal(serverEntryFields)
  221. if err != nil {
  222. return errors.Trace(err)
  223. }
  224. err = serverEntries.put(serverEntryID, data)
  225. if err != nil {
  226. return errors.Trace(err)
  227. }
  228. err = serverEntryTags.put(serverEntryTagBytes, serverEntryID)
  229. if err != nil {
  230. return errors.Trace(err)
  231. }
  232. NoticeInfo("updated server %s", serverEntryFields.GetDiagnosticID())
  233. return nil
  234. })
  235. if err != nil {
  236. return errors.Trace(err)
  237. }
  238. return nil
  239. }
  240. // StoreServerEntries stores a list of server entries.
  241. // There is an independent transaction for each entry insert/update.
  242. func StoreServerEntries(
  243. config *Config,
  244. serverEntries []protocol.ServerEntryFields,
  245. replaceIfExists bool) error {
  246. for _, serverEntryFields := range serverEntries {
  247. err := StoreServerEntry(serverEntryFields, replaceIfExists)
  248. if err != nil {
  249. return errors.Trace(err)
  250. }
  251. }
  252. return nil
  253. }
  254. // StreamingStoreServerEntries stores a list of server entries.
  255. // There is an independent transaction for each entry insert/update.
  256. func StreamingStoreServerEntries(
  257. config *Config,
  258. serverEntries *protocol.StreamingServerEntryDecoder,
  259. replaceIfExists bool) error {
  260. // Note: both StreamingServerEntryDecoder.Next and StoreServerEntry
  261. // allocate temporary memory buffers for hex/JSON decoding/encoding,
  262. // so this isn't true constant-memory streaming (it depends on garbage
  263. // collection).
  264. n := 0
  265. for {
  266. serverEntry, err := serverEntries.Next()
  267. if err != nil {
  268. return errors.Trace(err)
  269. }
  270. if serverEntry == nil {
  271. // No more server entries
  272. break
  273. }
  274. err = StoreServerEntry(serverEntry, replaceIfExists)
  275. if err != nil {
  276. return errors.Trace(err)
  277. }
  278. n += 1
  279. if n == datastoreServerEntryFetchGCThreshold {
  280. DoGarbageCollection()
  281. n = 0
  282. }
  283. }
  284. return nil
  285. }
  286. // PromoteServerEntry sets the server affinity server entry ID to the
  287. // specified server entry IP address.
  288. func PromoteServerEntry(config *Config, ipAddress string) error {
  289. err := datastoreUpdate(func(tx *datastoreTx) error {
  290. serverEntryID := []byte(ipAddress)
  291. // Ensure the corresponding server entry exists before
  292. // setting server affinity.
  293. bucket := tx.bucket(datastoreServerEntriesBucket)
  294. data := bucket.get(serverEntryID)
  295. if data == nil {
  296. NoticeWarning(
  297. "PromoteServerEntry: ignoring unknown server entry: %s",
  298. ipAddress)
  299. return nil
  300. }
  301. bucket = tx.bucket(datastoreKeyValueBucket)
  302. err := bucket.put(datastoreAffinityServerEntryIDKey, serverEntryID)
  303. if err != nil {
  304. return errors.Trace(err)
  305. }
  306. // Store the current server entry filter (e.g, region, etc.) that
  307. // was in use when the entry was promoted. This is used to detect
  308. // when the top ranked server entry was promoted under a different
  309. // filter.
  310. currentFilter, err := makeServerEntryFilterValue(config)
  311. if err != nil {
  312. return errors.Trace(err)
  313. }
  314. err = bucket.put(datastoreLastServerEntryFilterKey, currentFilter)
  315. if err != nil {
  316. return errors.Trace(err)
  317. }
  318. return nil
  319. })
  320. if err != nil {
  321. return errors.Trace(err)
  322. }
  323. return nil
  324. }
  325. // DeleteServerEntryAffinity clears server affinity if set to the specified
  326. // server.
  327. func DeleteServerEntryAffinity(ipAddress string) error {
  328. err := datastoreUpdate(func(tx *datastoreTx) error {
  329. serverEntryID := []byte(ipAddress)
  330. bucket := tx.bucket(datastoreKeyValueBucket)
  331. affinityServerEntryID := bucket.get(datastoreAffinityServerEntryIDKey)
  332. if bytes.Equal(affinityServerEntryID, serverEntryID) {
  333. err := bucket.delete(datastoreAffinityServerEntryIDKey)
  334. if err != nil {
  335. return errors.Trace(err)
  336. }
  337. err = bucket.delete(datastoreLastServerEntryFilterKey)
  338. if err != nil {
  339. return errors.Trace(err)
  340. }
  341. }
  342. return nil
  343. })
  344. if err != nil {
  345. return errors.Trace(err)
  346. }
  347. return nil
  348. }
  349. func makeServerEntryFilterValue(config *Config) ([]byte, error) {
  350. // Currently, only a change of EgressRegion will "break" server affinity.
  351. // If the tunnel protocol filter changes, any existing affinity server
  352. // either passes the new filter, or it will be skipped anyway.
  353. return []byte(config.EgressRegion), nil
  354. }
  355. func hasServerEntryFilterChanged(config *Config) (bool, error) {
  356. currentFilter, err := makeServerEntryFilterValue(config)
  357. if err != nil {
  358. return false, errors.Trace(err)
  359. }
  360. changed := false
  361. err = datastoreView(func(tx *datastoreTx) error {
  362. bucket := tx.bucket(datastoreKeyValueBucket)
  363. previousFilter := bucket.get(datastoreLastServerEntryFilterKey)
  364. // When not found, previousFilter will be nil; ensures this
  365. // results in "changed", even if currentFilter is len(0).
  366. if previousFilter == nil ||
  367. !bytes.Equal(previousFilter, currentFilter) {
  368. changed = true
  369. }
  370. return nil
  371. })
  372. if err != nil {
  373. return false, errors.Trace(err)
  374. }
  375. return changed, nil
  376. }
  377. // ServerEntryIterator is used to iterate over
  378. // stored server entries in rank order.
  379. type ServerEntryIterator struct {
  380. config *Config
  381. applyServerAffinity bool
  382. serverEntryIDs [][]byte
  383. serverEntryIndex int
  384. isTacticsServerEntryIterator bool
  385. isTargetServerEntryIterator bool
  386. hasNextTargetServerEntry bool
  387. targetServerEntry *protocol.ServerEntry
  388. }
  389. // NewServerEntryIterator creates a new ServerEntryIterator.
  390. //
  391. // The boolean return value indicates whether to treat the first server(s)
  392. // as affinity servers or not. When the server entry selection filter changes
  393. // such as from a specific region to any region, or when there was no previous
  394. // filter/iterator, the the first server(s) are arbitrary and should not be
  395. // given affinity treatment.
  396. //
  397. // NewServerEntryIterator and any returned ServerEntryIterator are not
  398. // designed for concurrent use as not all related datastore operations are
  399. // performed in a single transaction.
  400. //
  401. func NewServerEntryIterator(config *Config) (bool, *ServerEntryIterator, error) {
  402. // When configured, this target server entry is the only candidate
  403. if config.TargetServerEntry != "" {
  404. return newTargetServerEntryIterator(config, false)
  405. }
  406. filterChanged, err := hasServerEntryFilterChanged(config)
  407. if err != nil {
  408. return false, nil, errors.Trace(err)
  409. }
  410. applyServerAffinity := !filterChanged
  411. iterator := &ServerEntryIterator{
  412. config: config,
  413. applyServerAffinity: applyServerAffinity,
  414. }
  415. err = iterator.reset(true)
  416. if err != nil {
  417. return false, nil, errors.Trace(err)
  418. }
  419. return applyServerAffinity, iterator, nil
  420. }
  421. func NewTacticsServerEntryIterator(config *Config) (*ServerEntryIterator, error) {
  422. // When configured, this target server entry is the only candidate
  423. if config.TargetServerEntry != "" {
  424. _, iterator, err := newTargetServerEntryIterator(config, true)
  425. return iterator, err
  426. }
  427. iterator := &ServerEntryIterator{
  428. config: config,
  429. isTacticsServerEntryIterator: true,
  430. }
  431. err := iterator.reset(true)
  432. if err != nil {
  433. return nil, errors.Trace(err)
  434. }
  435. return iterator, nil
  436. }
  437. // newTargetServerEntryIterator is a helper for initializing the TargetServerEntry case
  438. func newTargetServerEntryIterator(config *Config, isTactics bool) (bool, *ServerEntryIterator, error) {
  439. serverEntry, err := protocol.DecodeServerEntry(
  440. config.TargetServerEntry, config.loadTimestamp, protocol.SERVER_ENTRY_SOURCE_TARGET)
  441. if err != nil {
  442. return false, nil, errors.Trace(err)
  443. }
  444. if serverEntry.Tag == "" {
  445. serverEntry.Tag = protocol.GenerateServerEntryTag(
  446. serverEntry.IpAddress, serverEntry.WebServerSecret)
  447. }
  448. if isTactics {
  449. if len(serverEntry.GetSupportedTacticsProtocols()) == 0 {
  450. return false, nil, errors.TraceNew("TargetServerEntry does not support tactics protocols")
  451. }
  452. } else {
  453. if config.EgressRegion != "" && serverEntry.Region != config.EgressRegion {
  454. return false, nil, errors.TraceNew("TargetServerEntry does not support EgressRegion")
  455. }
  456. limitTunnelProtocols := config.GetParameters().Get().TunnelProtocols(parameters.LimitTunnelProtocols)
  457. if len(limitTunnelProtocols) > 0 {
  458. // At the ServerEntryIterator level, only limitTunnelProtocols is applied;
  459. // excludeIntensive is handled higher up.
  460. if len(serverEntry.GetSupportedProtocols(
  461. conditionallyEnabledComponents{},
  462. config.UseUpstreamProxy(),
  463. limitTunnelProtocols,
  464. false)) == 0 {
  465. return false, nil, errors.Tracef(
  466. "TargetServerEntry does not support LimitTunnelProtocols: %v", limitTunnelProtocols)
  467. }
  468. }
  469. }
  470. iterator := &ServerEntryIterator{
  471. isTacticsServerEntryIterator: isTactics,
  472. isTargetServerEntryIterator: true,
  473. hasNextTargetServerEntry: true,
  474. targetServerEntry: serverEntry,
  475. }
  476. NoticeInfo("using TargetServerEntry: %s", serverEntry.GetDiagnosticID())
  477. return false, iterator, nil
  478. }
  479. // Reset a NewServerEntryIterator to the start of its cycle. The next
  480. // call to Next will return the first server entry.
  481. func (iterator *ServerEntryIterator) Reset() error {
  482. return iterator.reset(false)
  483. }
  484. func (iterator *ServerEntryIterator) reset(isInitialRound bool) error {
  485. iterator.Close()
  486. if iterator.isTargetServerEntryIterator {
  487. iterator.hasNextTargetServerEntry = true
  488. return nil
  489. }
  490. // Support stand-alone GetTactics operation. See TacticsStorer for more
  491. // details.
  492. if iterator.isTacticsServerEntryIterator {
  493. err := OpenDataStore(iterator.config)
  494. if err != nil {
  495. return errors.Trace(err)
  496. }
  497. defer CloseDataStore()
  498. }
  499. // BoltDB implementation note:
  500. // We don't keep a transaction open for the duration of the iterator
  501. // because this would expose the following semantics to consumer code:
  502. //
  503. // Read-only transactions and read-write transactions ... generally
  504. // shouldn't be opened simultaneously in the same goroutine. This can
  505. // cause a deadlock as the read-write transaction needs to periodically
  506. // re-map the data file but it cannot do so while a read-only
  507. // transaction is open.
  508. // (https://github.com/boltdb/bolt)
  509. //
  510. // So the underlying serverEntriesBucket could change after the serverEntryIDs
  511. // list is built.
  512. var serverEntryIDs [][]byte
  513. err := datastoreView(func(tx *datastoreTx) error {
  514. bucket := tx.bucket(datastoreKeyValueBucket)
  515. serverEntryIDs = make([][]byte, 0)
  516. shuffleHead := 0
  517. var affinityServerEntryID []byte
  518. // In the first round only, move any server affinity candiate to the
  519. // very first position.
  520. if isInitialRound &&
  521. iterator.applyServerAffinity {
  522. affinityServerEntryID = bucket.get(datastoreAffinityServerEntryIDKey)
  523. if affinityServerEntryID != nil {
  524. serverEntryIDs = append(serverEntryIDs, append([]byte(nil), affinityServerEntryID...))
  525. shuffleHead = 1
  526. }
  527. }
  528. bucket = tx.bucket(datastoreServerEntriesBucket)
  529. cursor := bucket.cursor()
  530. for key := cursor.firstKey(); key != nil; key = cursor.nextKey() {
  531. if affinityServerEntryID != nil {
  532. if bytes.Equal(affinityServerEntryID, key) {
  533. continue
  534. }
  535. }
  536. serverEntryIDs = append(serverEntryIDs, append([]byte(nil), key...))
  537. }
  538. cursor.close()
  539. // Randomly shuffle the entire list of server IDs, excluding the
  540. // server affinity candidate.
  541. for i := len(serverEntryIDs) - 1; i > shuffleHead-1; i-- {
  542. j := prng.Intn(i+1-shuffleHead) + shuffleHead
  543. serverEntryIDs[i], serverEntryIDs[j] = serverEntryIDs[j], serverEntryIDs[i]
  544. }
  545. // In the first round, or with some probability, move _potential_ replay
  546. // candidates to the front of the list (excepting the server affinity slot,
  547. // if any). This move is post-shuffle so the order is still randomized. To
  548. // save the memory overhead of unmarshalling all dial parameters, this
  549. // operation just moves any server with a dial parameter record to the
  550. // front. Whether the dial parameter remains valid for replay -- TTL,
  551. // tactics/config unchanged, etc. --- is checked later.
  552. //
  553. // TODO: move only up to parameters.ReplayCandidateCount to front?
  554. p := iterator.config.GetParameters().Get()
  555. if (isInitialRound || p.WeightedCoinFlip(parameters.ReplayLaterRoundMoveToFrontProbability)) &&
  556. p.Int(parameters.ReplayCandidateCount) != 0 {
  557. networkID := []byte(iterator.config.GetNetworkID())
  558. dialParamsBucket := tx.bucket(datastoreDialParametersBucket)
  559. i := shuffleHead
  560. j := len(serverEntryIDs) - 1
  561. for {
  562. for ; i < j; i++ {
  563. key := makeDialParametersKey(serverEntryIDs[i], networkID)
  564. if dialParamsBucket.get(key) == nil {
  565. break
  566. }
  567. }
  568. for ; i < j; j-- {
  569. key := makeDialParametersKey(serverEntryIDs[j], networkID)
  570. if dialParamsBucket.get(key) != nil {
  571. break
  572. }
  573. }
  574. if i < j {
  575. serverEntryIDs[i], serverEntryIDs[j] = serverEntryIDs[j], serverEntryIDs[i]
  576. i++
  577. j--
  578. } else {
  579. break
  580. }
  581. }
  582. }
  583. return nil
  584. })
  585. if err != nil {
  586. return errors.Trace(err)
  587. }
  588. iterator.serverEntryIDs = serverEntryIDs
  589. iterator.serverEntryIndex = 0
  590. return nil
  591. }
  592. // Close cleans up resources associated with a ServerEntryIterator.
  593. func (iterator *ServerEntryIterator) Close() {
  594. iterator.serverEntryIDs = nil
  595. iterator.serverEntryIndex = 0
  596. }
  597. // Next returns the next server entry, by rank, for a ServerEntryIterator.
  598. // Returns nil with no error when there is no next item.
  599. func (iterator *ServerEntryIterator) Next() (*protocol.ServerEntry, error) {
  600. var serverEntry *protocol.ServerEntry
  601. var err error
  602. defer func() {
  603. if err != nil {
  604. iterator.Close()
  605. }
  606. }()
  607. if iterator.isTargetServerEntryIterator {
  608. if iterator.hasNextTargetServerEntry {
  609. iterator.hasNextTargetServerEntry = false
  610. return MakeCompatibleServerEntry(iterator.targetServerEntry), nil
  611. }
  612. return nil, nil
  613. }
  614. // Support stand-alone GetTactics operation. See TacticsStorer for more
  615. // details.
  616. if iterator.isTacticsServerEntryIterator {
  617. err := OpenDataStore(iterator.config)
  618. if err != nil {
  619. return nil, errors.Trace(err)
  620. }
  621. defer CloseDataStore()
  622. }
  623. // There are no region/protocol indexes for the server entries bucket.
  624. // Loop until we have the next server entry that matches the iterator
  625. // filter requirements.
  626. for {
  627. if iterator.serverEntryIndex >= len(iterator.serverEntryIDs) {
  628. // There is no next item
  629. return nil, nil
  630. }
  631. serverEntryID := iterator.serverEntryIDs[iterator.serverEntryIndex]
  632. iterator.serverEntryIndex += 1
  633. serverEntry = nil
  634. doDeleteServerEntry := false
  635. err = datastoreView(func(tx *datastoreTx) error {
  636. serverEntries := tx.bucket(datastoreServerEntriesBucket)
  637. value := serverEntries.get(serverEntryID)
  638. if value == nil {
  639. return nil
  640. }
  641. // When the server entry has a signature and the signature verification
  642. // public key is configured, perform a signature verification, which will
  643. // detect data corruption of most server entry fields. When the check
  644. // fails, the server entry is deleted and skipped and iteration continues.
  645. //
  646. // This prevents wasteful, time-consuming dials in cases where the server
  647. // entry is intact except for a bit flip in the obfuscation key, for
  648. // example. A delete is triggered also in the case where the server entry
  649. // record fails to unmarshal.
  650. if iterator.config.ServerEntrySignaturePublicKey != "" {
  651. var serverEntryFields protocol.ServerEntryFields
  652. err = json.Unmarshal(value, &serverEntryFields)
  653. if err != nil {
  654. doDeleteServerEntry = true
  655. NoticeWarning(
  656. "ServerEntryIterator.Next: unmarshal failed: %s",
  657. errors.Trace(err))
  658. // Do not stop iterating.
  659. return nil
  660. }
  661. if serverEntryFields.HasSignature() {
  662. err = serverEntryFields.VerifySignature(
  663. iterator.config.ServerEntrySignaturePublicKey)
  664. if err != nil {
  665. doDeleteServerEntry = true
  666. NoticeWarning(
  667. "ServerEntryIterator.Next: verify signature failed: %s",
  668. errors.Trace(err))
  669. // Do not stop iterating.
  670. return nil
  671. }
  672. }
  673. }
  674. // Must unmarshal here as slice is only valid within transaction.
  675. err = json.Unmarshal(value, &serverEntry)
  676. if err != nil {
  677. serverEntry = nil
  678. doDeleteServerEntry = true
  679. NoticeWarning(
  680. "ServerEntryIterator.Next: unmarshal failed: %s",
  681. errors.Trace(err))
  682. // Do not stop iterating.
  683. return nil
  684. }
  685. return nil
  686. })
  687. if err != nil {
  688. return nil, errors.Trace(err)
  689. }
  690. if doDeleteServerEntry {
  691. deleteServerEntry(iterator.config, serverEntryID)
  692. continue
  693. }
  694. if serverEntry == nil {
  695. // In case of data corruption or a bug causing this condition,
  696. // do not stop iterating.
  697. NoticeWarning("ServerEntryIterator.Next: unexpected missing server entry")
  698. continue
  699. }
  700. // Generate a derived server entry tag for server entries with no tag. Store
  701. // back the updated server entry so that (a) the tag doesn't need to be
  702. // regenerated; (b) the server entry can be looked up by tag (currently used
  703. // in the status request prune case).
  704. //
  705. // This is a distinct transaction so as to avoid the overhead of regular
  706. // write transactions in the iterator; once tags have been stored back, most
  707. // iterator transactions will remain read-only.
  708. if serverEntry.Tag == "" {
  709. serverEntry.Tag = protocol.GenerateServerEntryTag(
  710. serverEntry.IpAddress, serverEntry.WebServerSecret)
  711. err = datastoreUpdate(func(tx *datastoreTx) error {
  712. serverEntries := tx.bucket(datastoreServerEntriesBucket)
  713. serverEntryTags := tx.bucket(datastoreServerEntryTagsBucket)
  714. // We must reload and store back the server entry _fields_ to preserve any
  715. // currently unrecognized fields, for future compatibility.
  716. value := serverEntries.get(serverEntryID)
  717. if value == nil {
  718. return nil
  719. }
  720. var serverEntryFields protocol.ServerEntryFields
  721. err := json.Unmarshal(value, &serverEntryFields)
  722. if err != nil {
  723. return errors.Trace(err)
  724. }
  725. // As there is minor race condition between loading/checking serverEntry
  726. // and reloading/modifying serverEntryFields, this transaction references
  727. // only the freshly loaded fields when checking and setting the tag.
  728. serverEntryTag := serverEntryFields.GetTag()
  729. if serverEntryTag != "" {
  730. return nil
  731. }
  732. serverEntryTag = protocol.GenerateServerEntryTag(
  733. serverEntryFields.GetIPAddress(),
  734. serverEntryFields.GetWebServerSecret())
  735. serverEntryFields.SetTag(serverEntryTag)
  736. jsonServerEntryFields, err := json.Marshal(serverEntryFields)
  737. if err != nil {
  738. return errors.Trace(err)
  739. }
  740. serverEntries.put(serverEntryID, jsonServerEntryFields)
  741. if err != nil {
  742. return errors.Trace(err)
  743. }
  744. serverEntryTags.put([]byte(serverEntryTag), serverEntryID)
  745. if err != nil {
  746. return errors.Trace(err)
  747. }
  748. return nil
  749. })
  750. if err != nil {
  751. // Do not stop.
  752. NoticeWarning(
  753. "ServerEntryIterator.Next: update server entry failed: %s",
  754. errors.Trace(err))
  755. }
  756. }
  757. if iterator.serverEntryIndex%datastoreServerEntryFetchGCThreshold == 0 {
  758. DoGarbageCollection()
  759. }
  760. // Check filter requirements
  761. if iterator.isTacticsServerEntryIterator {
  762. // Tactics doesn't filter by egress region.
  763. if len(serverEntry.GetSupportedTacticsProtocols()) > 0 {
  764. break
  765. }
  766. } else {
  767. if iterator.config.EgressRegion == "" ||
  768. serverEntry.Region == iterator.config.EgressRegion {
  769. break
  770. }
  771. }
  772. }
  773. return MakeCompatibleServerEntry(serverEntry), nil
  774. }
  775. // MakeCompatibleServerEntry provides backwards compatibility with old server entries
  776. // which have a single meekFrontingDomain and not a meekFrontingAddresses array.
  777. // By copying this one meekFrontingDomain into meekFrontingAddresses, this client effectively
  778. // uses that single value as legacy clients do.
  779. func MakeCompatibleServerEntry(serverEntry *protocol.ServerEntry) *protocol.ServerEntry {
  780. if len(serverEntry.MeekFrontingAddresses) == 0 && serverEntry.MeekFrontingDomain != "" {
  781. serverEntry.MeekFrontingAddresses =
  782. append(serverEntry.MeekFrontingAddresses, serverEntry.MeekFrontingDomain)
  783. }
  784. return serverEntry
  785. }
  786. // PruneServerEntry deletes the server entry, along with associated data,
  787. // corresponding to the specified server entry tag. Pruning is subject to an
  788. // age check. In the case of an error, a notice is emitted.
  789. func PruneServerEntry(config *Config, serverEntryTag string) {
  790. err := pruneServerEntry(config, serverEntryTag)
  791. if err != nil {
  792. NoticeWarning(
  793. "PruneServerEntry failed: %s: %s",
  794. serverEntryTag, errors.Trace(err))
  795. return
  796. }
  797. NoticePruneServerEntry(serverEntryTag)
  798. }
  799. func pruneServerEntry(config *Config, serverEntryTag string) error {
  800. minimumAgeForPruning := config.GetParameters().Get().Duration(
  801. parameters.ServerEntryMinimumAgeForPruning)
  802. return datastoreUpdate(func(tx *datastoreTx) error {
  803. serverEntries := tx.bucket(datastoreServerEntriesBucket)
  804. serverEntryTags := tx.bucket(datastoreServerEntryTagsBucket)
  805. serverEntryTombstoneTags := tx.bucket(datastoreServerEntryTombstoneTagsBucket)
  806. keyValues := tx.bucket(datastoreKeyValueBucket)
  807. dialParameters := tx.bucket(datastoreDialParametersBucket)
  808. serverEntryTagBytes := []byte(serverEntryTag)
  809. serverEntryID := serverEntryTags.get(serverEntryTagBytes)
  810. if serverEntryID == nil {
  811. return errors.TraceNew("server entry tag not found")
  812. }
  813. serverEntryJson := serverEntries.get(serverEntryID)
  814. if serverEntryJson == nil {
  815. return errors.TraceNew("server entry not found")
  816. }
  817. var serverEntry *protocol.ServerEntry
  818. err := json.Unmarshal(serverEntryJson, &serverEntry)
  819. if err != nil {
  820. errors.Trace(err)
  821. }
  822. // Only prune sufficiently old server entries. This mitigates the case where
  823. // stale data in psiphond will incorrectly identify brand new servers as
  824. // being invalid/deleted.
  825. serverEntryLocalTimestamp, err := time.Parse(time.RFC3339, serverEntry.LocalTimestamp)
  826. if err != nil {
  827. errors.Trace(err)
  828. }
  829. if serverEntryLocalTimestamp.Add(minimumAgeForPruning).After(time.Now()) {
  830. return nil
  831. }
  832. // Handle the server IP recycle case where multiple serverEntryTags records
  833. // refer to the same server IP. Only delete the server entry record when its
  834. // tag matches the pruned tag. Otherwise, the server entry record is
  835. // associated with another tag. The pruned tag is still deleted.
  836. doDeleteServerEntry := (serverEntry.Tag == serverEntryTag)
  837. err = serverEntryTags.delete(serverEntryTagBytes)
  838. if err != nil {
  839. errors.Trace(err)
  840. }
  841. if doDeleteServerEntry {
  842. err = deleteServerEntryHelper(
  843. config,
  844. serverEntryID,
  845. serverEntries,
  846. keyValues,
  847. dialParameters)
  848. if err != nil {
  849. errors.Trace(err)
  850. }
  851. }
  852. // Tombstones prevent reimporting pruned server entries. Tombstone
  853. // identifiers are tags, which are derived from the web server secret in
  854. // addition to the server IP, so tombstones will not clobber recycled server
  855. // IPs as long as new web server secrets are generated in the recycle case.
  856. //
  857. // Tombstones are set only for embedded server entries, as all other sources
  858. // are expected to provide valid server entries; this also provides a fail-
  859. // safe mechanism to restore pruned server entries through all non-embedded
  860. // sources.
  861. if serverEntry.LocalSource == protocol.SERVER_ENTRY_SOURCE_EMBEDDED {
  862. err = serverEntryTombstoneTags.put(serverEntryTagBytes, []byte{1})
  863. if err != nil {
  864. return errors.Trace(err)
  865. }
  866. }
  867. return nil
  868. })
  869. }
  870. // DeleteServerEntry deletes the specified server entry and associated data.
  871. func DeleteServerEntry(config *Config, ipAddress string) {
  872. serverEntryID := []byte(ipAddress)
  873. // For notices, we cannot assume we have a valid server entry tag value to
  874. // log, as DeleteServerEntry is called when a server entry fails to unmarshal
  875. // or fails signature verification.
  876. err := deleteServerEntry(config, serverEntryID)
  877. if err != nil {
  878. NoticeWarning("DeleteServerEntry failed: %s", errors.Trace(err))
  879. return
  880. }
  881. NoticeInfo("Server entry deleted")
  882. }
  883. func deleteServerEntry(config *Config, serverEntryID []byte) error {
  884. return datastoreUpdate(func(tx *datastoreTx) error {
  885. serverEntries := tx.bucket(datastoreServerEntriesBucket)
  886. serverEntryTags := tx.bucket(datastoreServerEntryTagsBucket)
  887. keyValues := tx.bucket(datastoreKeyValueBucket)
  888. dialParameters := tx.bucket(datastoreDialParametersBucket)
  889. err := deleteServerEntryHelper(
  890. config,
  891. serverEntryID,
  892. serverEntries,
  893. keyValues,
  894. dialParameters)
  895. if err != nil {
  896. errors.Trace(err)
  897. }
  898. // Remove any tags pointing to the deleted server entry.
  899. cursor := serverEntryTags.cursor()
  900. defer cursor.close()
  901. for key, value := cursor.first(); key != nil; key, value = cursor.next() {
  902. if bytes.Equal(value, serverEntryID) {
  903. err := serverEntryTags.delete(key)
  904. if err != nil {
  905. return errors.Trace(err)
  906. }
  907. }
  908. }
  909. return nil
  910. })
  911. }
  912. func deleteServerEntryHelper(
  913. config *Config,
  914. serverEntryID []byte,
  915. serverEntries *datastoreBucket,
  916. keyValues *datastoreBucket,
  917. dialParameters *datastoreBucket) error {
  918. err := serverEntries.delete(serverEntryID)
  919. if err != nil {
  920. errors.Trace(err)
  921. }
  922. affinityServerEntryID := keyValues.get(datastoreAffinityServerEntryIDKey)
  923. if bytes.Equal(affinityServerEntryID, serverEntryID) {
  924. err = keyValues.delete(datastoreAffinityServerEntryIDKey)
  925. if err != nil {
  926. return errors.Trace(err)
  927. }
  928. err = keyValues.delete(datastoreLastServerEntryFilterKey)
  929. if err != nil {
  930. return errors.Trace(err)
  931. }
  932. }
  933. // TODO: expose boltdb Seek functionality to skip to first matching record.
  934. cursor := dialParameters.cursor()
  935. defer cursor.close()
  936. foundFirstMatch := false
  937. for key, _ := cursor.first(); key != nil; key, _ = cursor.next() {
  938. // Dial parameters key has serverID as a prefix; see makeDialParametersKey.
  939. if bytes.HasPrefix(key, serverEntryID) {
  940. foundFirstMatch = true
  941. err := dialParameters.delete(key)
  942. if err != nil {
  943. return errors.Trace(err)
  944. }
  945. } else if foundFirstMatch {
  946. break
  947. }
  948. }
  949. return nil
  950. }
  951. func scanServerEntries(scanner func(*protocol.ServerEntry)) error {
  952. err := datastoreView(func(tx *datastoreTx) error {
  953. bucket := tx.bucket(datastoreServerEntriesBucket)
  954. cursor := bucket.cursor()
  955. n := 0
  956. for key, value := cursor.first(); key != nil; key, value = cursor.next() {
  957. var serverEntry *protocol.ServerEntry
  958. err := json.Unmarshal(value, &serverEntry)
  959. if err != nil {
  960. // In case of data corruption or a bug causing this condition,
  961. // do not stop iterating.
  962. NoticeWarning("scanServerEntries: %s", errors.Trace(err))
  963. continue
  964. }
  965. scanner(serverEntry)
  966. n += 1
  967. if n == datastoreServerEntryFetchGCThreshold {
  968. DoGarbageCollection()
  969. n = 0
  970. }
  971. }
  972. cursor.close()
  973. return nil
  974. })
  975. if err != nil {
  976. return errors.Trace(err)
  977. }
  978. return nil
  979. }
  980. // CountServerEntries returns a count of stored server entries.
  981. func CountServerEntries() int {
  982. count := 0
  983. err := scanServerEntries(func(_ *protocol.ServerEntry) {
  984. count += 1
  985. })
  986. if err != nil {
  987. NoticeWarning("CountServerEntries failed: %s", err)
  988. return 0
  989. }
  990. return count
  991. }
  992. // CountServerEntriesWithConstraints returns a count of stored server entries for
  993. // the specified region and tunnel protocol limits.
  994. func CountServerEntriesWithConstraints(
  995. useUpstreamProxy bool,
  996. region string,
  997. constraints *protocolSelectionConstraints) (int, int) {
  998. // When CountServerEntriesWithConstraints is called only
  999. // limitTunnelProtocolState is fixed; excludeIntensive is transitory.
  1000. excludeIntensive := false
  1001. initialCount := 0
  1002. count := 0
  1003. err := scanServerEntries(func(serverEntry *protocol.ServerEntry) {
  1004. if region == "" || serverEntry.Region == region {
  1005. if constraints.isInitialCandidate(excludeIntensive, serverEntry) {
  1006. initialCount += 1
  1007. }
  1008. if constraints.isCandidate(excludeIntensive, serverEntry) {
  1009. count += 1
  1010. }
  1011. }
  1012. })
  1013. if err != nil {
  1014. NoticeWarning("CountServerEntriesWithConstraints failed: %s", err)
  1015. return 0, 0
  1016. }
  1017. return initialCount, count
  1018. }
  1019. // ReportAvailableRegions prints a notice with the available egress regions.
  1020. // When limitState has initial protocols, the available regions are limited
  1021. // to those available for the initial protocols; or if limitState has general
  1022. // limited protocols, the available regions are similarly limited.
  1023. func ReportAvailableRegions(config *Config, constraints *protocolSelectionConstraints) {
  1024. // When ReportAvailableRegions is called only limitTunnelProtocolState is
  1025. // fixed; excludeIntensive is transitory.
  1026. excludeIntensive := false
  1027. regions := make(map[string]bool)
  1028. err := scanServerEntries(func(serverEntry *protocol.ServerEntry) {
  1029. isCandidate := false
  1030. if constraints.hasInitialProtocols() {
  1031. isCandidate = constraints.isInitialCandidate(excludeIntensive, serverEntry)
  1032. } else {
  1033. isCandidate = constraints.isCandidate(excludeIntensive, serverEntry)
  1034. }
  1035. if isCandidate {
  1036. regions[serverEntry.Region] = true
  1037. }
  1038. })
  1039. if err != nil {
  1040. NoticeWarning("ReportAvailableRegions failed: %s", err)
  1041. return
  1042. }
  1043. regionList := make([]string, 0, len(regions))
  1044. for region := range regions {
  1045. // Some server entries do not have a region, but it makes no sense to return
  1046. // an empty string as an "available region".
  1047. if region != "" {
  1048. regionList = append(regionList, region)
  1049. }
  1050. }
  1051. NoticeAvailableEgressRegions(regionList)
  1052. }
  1053. // SetSplitTunnelRoutes updates the cached routes data for
  1054. // the given region. The associated etag is also stored and
  1055. // used to make efficient web requests for updates to the data.
  1056. func SetSplitTunnelRoutes(region, etag string, data []byte) error {
  1057. err := datastoreUpdate(func(tx *datastoreTx) error {
  1058. bucket := tx.bucket(datastoreSplitTunnelRouteETagsBucket)
  1059. err := bucket.put([]byte(region), []byte(etag))
  1060. if err != nil {
  1061. return errors.Trace(err)
  1062. }
  1063. bucket = tx.bucket(datastoreSplitTunnelRouteDataBucket)
  1064. err = bucket.put([]byte(region), data)
  1065. if err != nil {
  1066. return errors.Trace(err)
  1067. }
  1068. return nil
  1069. })
  1070. if err != nil {
  1071. return errors.Trace(err)
  1072. }
  1073. return nil
  1074. }
  1075. // GetSplitTunnelRoutesETag retrieves the etag for cached routes
  1076. // data for the specified region. If not found, it returns an empty string value.
  1077. func GetSplitTunnelRoutesETag(region string) (string, error) {
  1078. var etag string
  1079. err := datastoreView(func(tx *datastoreTx) error {
  1080. bucket := tx.bucket(datastoreSplitTunnelRouteETagsBucket)
  1081. etag = string(bucket.get([]byte(region)))
  1082. return nil
  1083. })
  1084. if err != nil {
  1085. return "", errors.Trace(err)
  1086. }
  1087. return etag, nil
  1088. }
  1089. // GetSplitTunnelRoutesData retrieves the cached routes data
  1090. // for the specified region. If not found, it returns a nil value.
  1091. func GetSplitTunnelRoutesData(region string) ([]byte, error) {
  1092. var data []byte
  1093. err := datastoreView(func(tx *datastoreTx) error {
  1094. bucket := tx.bucket(datastoreSplitTunnelRouteDataBucket)
  1095. value := bucket.get([]byte(region))
  1096. if value != nil {
  1097. // Must make a copy as slice is only valid within transaction.
  1098. data = make([]byte, len(value))
  1099. copy(data, value)
  1100. }
  1101. return nil
  1102. })
  1103. if err != nil {
  1104. return nil, errors.Trace(err)
  1105. }
  1106. return data, nil
  1107. }
  1108. // SetUrlETag stores an ETag for the specfied URL.
  1109. // Note: input URL is treated as a string, and is not
  1110. // encoded or decoded or otherwise canonicalized.
  1111. func SetUrlETag(url, etag string) error {
  1112. err := datastoreUpdate(func(tx *datastoreTx) error {
  1113. bucket := tx.bucket(datastoreUrlETagsBucket)
  1114. err := bucket.put([]byte(url), []byte(etag))
  1115. if err != nil {
  1116. return errors.Trace(err)
  1117. }
  1118. return nil
  1119. })
  1120. if err != nil {
  1121. return errors.Trace(err)
  1122. }
  1123. return nil
  1124. }
  1125. // GetUrlETag retrieves a previously stored an ETag for the
  1126. // specfied URL. If not found, it returns an empty string value.
  1127. func GetUrlETag(url string) (string, error) {
  1128. var etag string
  1129. err := datastoreView(func(tx *datastoreTx) error {
  1130. bucket := tx.bucket(datastoreUrlETagsBucket)
  1131. etag = string(bucket.get([]byte(url)))
  1132. return nil
  1133. })
  1134. if err != nil {
  1135. return "", errors.Trace(err)
  1136. }
  1137. return etag, nil
  1138. }
  1139. // SetKeyValue stores a key/value pair.
  1140. func SetKeyValue(key, value string) error {
  1141. err := datastoreUpdate(func(tx *datastoreTx) error {
  1142. bucket := tx.bucket(datastoreKeyValueBucket)
  1143. err := bucket.put([]byte(key), []byte(value))
  1144. if err != nil {
  1145. return errors.Trace(err)
  1146. }
  1147. return nil
  1148. })
  1149. if err != nil {
  1150. return errors.Trace(err)
  1151. }
  1152. return nil
  1153. }
  1154. // GetKeyValue retrieves the value for a given key. If not found,
  1155. // it returns an empty string value.
  1156. func GetKeyValue(key string) (string, error) {
  1157. var value string
  1158. err := datastoreView(func(tx *datastoreTx) error {
  1159. bucket := tx.bucket(datastoreKeyValueBucket)
  1160. value = string(bucket.get([]byte(key)))
  1161. return nil
  1162. })
  1163. if err != nil {
  1164. return "", errors.Trace(err)
  1165. }
  1166. return value, nil
  1167. }
  1168. // Persistent stat records in the persistentStatStateUnreported
  1169. // state are available for take out.
  1170. //
  1171. // Records in the persistentStatStateReporting have been taken
  1172. // out and are pending either deletion (for a successful request)
  1173. // or change to StateUnreported (for a failed request).
  1174. //
  1175. // All persistent stat records are reverted to StateUnreported
  1176. // when the datastore is initialized at start up.
  1177. var persistentStatStateUnreported = []byte("0")
  1178. var persistentStatStateReporting = []byte("1")
  1179. var persistentStatTypes = []string{
  1180. datastorePersistentStatTypeRemoteServerList,
  1181. datastorePersistentStatTypeFailedTunnel,
  1182. }
  1183. // StorePersistentStat adds a new persistent stat record, which
  1184. // is set to StateUnreported and is an immediate candidate for
  1185. // reporting.
  1186. //
  1187. // The stat is a JSON byte array containing fields as
  1188. // required by the Psiphon server API. It's assumed that the
  1189. // JSON value contains enough unique information for the value to
  1190. // function as a key in the key/value datastore.
  1191. //
  1192. // Only up to PersistentStatsMaxStoreRecords are stored. Once this
  1193. // limit is reached, new records are discarded.
  1194. func StorePersistentStat(config *Config, statType string, stat []byte) error {
  1195. if !common.Contains(persistentStatTypes, statType) {
  1196. return errors.Tracef("invalid persistent stat type: %s", statType)
  1197. }
  1198. maxStoreRecords := config.GetParameters().Get().Int(
  1199. parameters.PersistentStatsMaxStoreRecords)
  1200. err := datastoreUpdate(func(tx *datastoreTx) error {
  1201. bucket := tx.bucket([]byte(statType))
  1202. count := 0
  1203. cursor := bucket.cursor()
  1204. for key, _ := cursor.first(); key != nil; key, _ = cursor.next() {
  1205. count++
  1206. }
  1207. cursor.close()
  1208. // TODO: assuming newer metrics are more useful, replace oldest record
  1209. // instead of discarding?
  1210. if count >= maxStoreRecords {
  1211. // Silently discard.
  1212. return nil
  1213. }
  1214. err := bucket.put(stat, persistentStatStateUnreported)
  1215. if err != nil {
  1216. return errors.Trace(err)
  1217. }
  1218. return nil
  1219. })
  1220. if err != nil {
  1221. return errors.Trace(err)
  1222. }
  1223. return nil
  1224. }
  1225. // CountUnreportedPersistentStats returns the number of persistent
  1226. // stat records in StateUnreported.
  1227. func CountUnreportedPersistentStats() int {
  1228. unreported := 0
  1229. err := datastoreView(func(tx *datastoreTx) error {
  1230. for _, statType := range persistentStatTypes {
  1231. bucket := tx.bucket([]byte(statType))
  1232. cursor := bucket.cursor()
  1233. for key, value := cursor.first(); key != nil; key, value = cursor.next() {
  1234. if bytes.Equal(value, persistentStatStateUnreported) {
  1235. unreported++
  1236. }
  1237. }
  1238. cursor.close()
  1239. }
  1240. return nil
  1241. })
  1242. if err != nil {
  1243. NoticeWarning("CountUnreportedPersistentStats failed: %s", err)
  1244. return 0
  1245. }
  1246. return unreported
  1247. }
  1248. // TakeOutUnreportedPersistentStats returns persistent stats records that are
  1249. // in StateUnreported. At least one record, if present, will be returned and
  1250. // then additional records up to PersistentStatsMaxSendBytes. The records are
  1251. // set to StateReporting. If the records are successfully reported, clear them
  1252. // with ClearReportedPersistentStats. If the records are not successfully
  1253. // reported, restore them with PutBackUnreportedPersistentStats.
  1254. func TakeOutUnreportedPersistentStats(config *Config) (map[string][][]byte, error) {
  1255. stats := make(map[string][][]byte)
  1256. maxSendBytes := config.GetParameters().Get().Int(
  1257. parameters.PersistentStatsMaxSendBytes)
  1258. err := datastoreUpdate(func(tx *datastoreTx) error {
  1259. sendBytes := 0
  1260. for _, statType := range persistentStatTypes {
  1261. bucket := tx.bucket([]byte(statType))
  1262. cursor := bucket.cursor()
  1263. for key, value := cursor.first(); key != nil; key, value = cursor.next() {
  1264. // Perform a test JSON unmarshaling. In case of data corruption or a bug,
  1265. // delete and skip the record.
  1266. var jsonData interface{}
  1267. err := json.Unmarshal(key, &jsonData)
  1268. if err != nil {
  1269. NoticeWarning(
  1270. "Invalid key in TakeOutUnreportedPersistentStats: %s: %s",
  1271. string(key), err)
  1272. bucket.delete(key)
  1273. continue
  1274. }
  1275. if bytes.Equal(value, persistentStatStateUnreported) {
  1276. // Must make a copy as slice is only valid within transaction.
  1277. data := make([]byte, len(key))
  1278. copy(data, key)
  1279. if stats[statType] == nil {
  1280. stats[statType] = make([][]byte, 0)
  1281. }
  1282. stats[statType] = append(stats[statType], data)
  1283. sendBytes += len(data)
  1284. if sendBytes >= maxSendBytes {
  1285. break
  1286. }
  1287. }
  1288. }
  1289. cursor.close()
  1290. for _, key := range stats[statType] {
  1291. err := bucket.put(key, persistentStatStateReporting)
  1292. if err != nil {
  1293. return errors.Trace(err)
  1294. }
  1295. }
  1296. }
  1297. return nil
  1298. })
  1299. if err != nil {
  1300. return nil, errors.Trace(err)
  1301. }
  1302. return stats, nil
  1303. }
  1304. // PutBackUnreportedPersistentStats restores a list of persistent
  1305. // stat records to StateUnreported.
  1306. func PutBackUnreportedPersistentStats(stats map[string][][]byte) error {
  1307. err := datastoreUpdate(func(tx *datastoreTx) error {
  1308. for _, statType := range persistentStatTypes {
  1309. bucket := tx.bucket([]byte(statType))
  1310. for _, key := range stats[statType] {
  1311. err := bucket.put(key, persistentStatStateUnreported)
  1312. if err != nil {
  1313. return errors.Trace(err)
  1314. }
  1315. }
  1316. }
  1317. return nil
  1318. })
  1319. if err != nil {
  1320. return errors.Trace(err)
  1321. }
  1322. return nil
  1323. }
  1324. // ClearReportedPersistentStats deletes a list of persistent
  1325. // stat records that were successfully reported.
  1326. func ClearReportedPersistentStats(stats map[string][][]byte) error {
  1327. err := datastoreUpdate(func(tx *datastoreTx) error {
  1328. for _, statType := range persistentStatTypes {
  1329. bucket := tx.bucket([]byte(statType))
  1330. for _, key := range stats[statType] {
  1331. err := bucket.delete(key)
  1332. if err != nil {
  1333. return err
  1334. }
  1335. }
  1336. }
  1337. return nil
  1338. })
  1339. if err != nil {
  1340. return errors.Trace(err)
  1341. }
  1342. return nil
  1343. }
  1344. // resetAllPersistentStatsToUnreported sets all persistent stat
  1345. // records to StateUnreported. This reset is called when the
  1346. // datastore is initialized at start up, as we do not know if
  1347. // persistent records in StateReporting were reported or not.
  1348. func resetAllPersistentStatsToUnreported() error {
  1349. err := datastoreUpdate(func(tx *datastoreTx) error {
  1350. for _, statType := range persistentStatTypes {
  1351. bucket := tx.bucket([]byte(statType))
  1352. resetKeys := make([][]byte, 0)
  1353. cursor := bucket.cursor()
  1354. for key := cursor.firstKey(); key != nil; key = cursor.nextKey() {
  1355. resetKeys = append(resetKeys, key)
  1356. }
  1357. cursor.close()
  1358. // TODO: data mutation is done outside cursor. Is this
  1359. // strictly necessary in this case? As is, this means
  1360. // all stats need to be loaded into memory at once.
  1361. // https://godoc.org/github.com/boltdb/bolt#Cursor
  1362. for _, key := range resetKeys {
  1363. err := bucket.put(key, persistentStatStateUnreported)
  1364. if err != nil {
  1365. return errors.Trace(err)
  1366. }
  1367. }
  1368. }
  1369. return nil
  1370. })
  1371. if err != nil {
  1372. return errors.Trace(err)
  1373. }
  1374. return nil
  1375. }
  1376. // CountSLOKs returns the total number of SLOK records.
  1377. func CountSLOKs() int {
  1378. count := 0
  1379. err := datastoreView(func(tx *datastoreTx) error {
  1380. bucket := tx.bucket(datastoreSLOKsBucket)
  1381. cursor := bucket.cursor()
  1382. for key := cursor.firstKey(); key != nil; key = cursor.nextKey() {
  1383. count++
  1384. }
  1385. cursor.close()
  1386. return nil
  1387. })
  1388. if err != nil {
  1389. NoticeWarning("CountSLOKs failed: %s", err)
  1390. return 0
  1391. }
  1392. return count
  1393. }
  1394. // DeleteSLOKs deletes all SLOK records.
  1395. func DeleteSLOKs() error {
  1396. err := datastoreUpdate(func(tx *datastoreTx) error {
  1397. return tx.clearBucket(datastoreSLOKsBucket)
  1398. })
  1399. if err != nil {
  1400. return errors.Trace(err)
  1401. }
  1402. return nil
  1403. }
  1404. // SetSLOK stores a SLOK key, referenced by its ID. The bool
  1405. // return value indicates whether the SLOK was already stored.
  1406. func SetSLOK(id, slok []byte) (bool, error) {
  1407. var duplicate bool
  1408. err := datastoreUpdate(func(tx *datastoreTx) error {
  1409. bucket := tx.bucket(datastoreSLOKsBucket)
  1410. duplicate = bucket.get(id) != nil
  1411. err := bucket.put(id, slok)
  1412. if err != nil {
  1413. return errors.Trace(err)
  1414. }
  1415. return nil
  1416. })
  1417. if err != nil {
  1418. return false, errors.Trace(err)
  1419. }
  1420. return duplicate, nil
  1421. }
  1422. // GetSLOK returns a SLOK key for the specified ID. The return
  1423. // value is nil if the SLOK is not found.
  1424. func GetSLOK(id []byte) ([]byte, error) {
  1425. var slok []byte
  1426. err := datastoreView(func(tx *datastoreTx) error {
  1427. bucket := tx.bucket(datastoreSLOKsBucket)
  1428. value := bucket.get(id)
  1429. if value != nil {
  1430. // Must make a copy as slice is only valid within transaction.
  1431. slok = make([]byte, len(value))
  1432. copy(slok, value)
  1433. }
  1434. return nil
  1435. })
  1436. if err != nil {
  1437. return nil, errors.Trace(err)
  1438. }
  1439. return slok, nil
  1440. }
  1441. func makeDialParametersKey(serverIPAddress, networkID []byte) []byte {
  1442. // TODO: structured key?
  1443. return append(append([]byte(nil), serverIPAddress...), networkID...)
  1444. }
  1445. // SetDialParameters stores dial parameters associated with the specified
  1446. // server/network ID.
  1447. func SetDialParameters(serverIPAddress, networkID string, dialParams *DialParameters) error {
  1448. key := makeDialParametersKey([]byte(serverIPAddress), []byte(networkID))
  1449. data, err := json.Marshal(dialParams)
  1450. if err != nil {
  1451. return errors.Trace(err)
  1452. }
  1453. return setBucketValue(datastoreDialParametersBucket, key, data)
  1454. }
  1455. // GetDialParameters fetches any dial parameters associated with the specified
  1456. // server/network ID. Returns nil, nil when no record is found.
  1457. func GetDialParameters(serverIPAddress, networkID string) (*DialParameters, error) {
  1458. key := makeDialParametersKey([]byte(serverIPAddress), []byte(networkID))
  1459. var dialParams *DialParameters
  1460. err := getBucketValue(
  1461. datastoreDialParametersBucket,
  1462. key,
  1463. func(value []byte) error {
  1464. if value == nil {
  1465. return nil
  1466. }
  1467. // Note: unlike with server entries, this record is not deleted when the
  1468. // unmarshal fails, as the caller should proceed with the dial without dial
  1469. // parameters; and when when the dial succeeds, new dial parameters will be
  1470. // written over this record.
  1471. err := json.Unmarshal(value, &dialParams)
  1472. if err != nil {
  1473. return errors.Trace(err)
  1474. }
  1475. return nil
  1476. })
  1477. if err != nil {
  1478. return nil, errors.Trace(err)
  1479. }
  1480. return dialParams, nil
  1481. }
  1482. // DeleteDialParameters clears any dial parameters associated with the
  1483. // specified server/network ID.
  1484. func DeleteDialParameters(serverIPAddress, networkID string) error {
  1485. key := makeDialParametersKey([]byte(serverIPAddress), []byte(networkID))
  1486. return deleteBucketValue(datastoreDialParametersBucket, key)
  1487. }
  1488. // TacticsStorer implements tactics.Storer.
  1489. //
  1490. // Each TacticsStorer datastore operation is wrapped with
  1491. // OpenDataStore/CloseDataStore, which enables a limited degree of
  1492. // multiprocess datastore synchronization:
  1493. //
  1494. // One process runs a Controller. Another process runs a stand-alone operation
  1495. // which accesses tactics via GetTactics. For example, SendFeedback.
  1496. //
  1497. // When the Controller is running, it holds an exclusive lock on the datastore
  1498. // and TacticsStorer operations in GetTactics in another process will fail.
  1499. // The stand-alone operation should proceed without tactics. In many cases,
  1500. // this is acceptable since any stand-alone operation network traffic will be
  1501. // tunneled.
  1502. //
  1503. // When the Controller is not running, the TacticsStorer operations in
  1504. // GetTactics in another process will succeed, with no operation holding a
  1505. // datastore lock for longer than the handful of milliseconds required to
  1506. // perform a single datastore operation.
  1507. //
  1508. // If the Controller is started while the stand-alone operation is in
  1509. // progress, the Controller start will not be blocked by the brief
  1510. // TacticsStorer datastore locks; the bolt Open call, in particular, has a 1
  1511. // second lock aquisition timeout.
  1512. //
  1513. // In this scheme, no attempt is made to detect interleaving datastore writes;
  1514. // that is, if a different process writes tactics in between GetTactics calls
  1515. // to GetTacticsRecord and then SetTacticsRecord. This is because all tactics
  1516. // writes are considered fresh and valid.
  1517. type TacticsStorer struct {
  1518. config *Config
  1519. }
  1520. func (t *TacticsStorer) SetTacticsRecord(networkID string, record []byte) error {
  1521. err := OpenDataStore(t.config)
  1522. if err != nil {
  1523. return errors.Trace(err)
  1524. }
  1525. defer CloseDataStore()
  1526. err = setBucketValue(datastoreTacticsBucket, []byte(networkID), record)
  1527. if err != nil {
  1528. return errors.Trace(err)
  1529. }
  1530. return nil
  1531. }
  1532. func (t *TacticsStorer) GetTacticsRecord(networkID string) ([]byte, error) {
  1533. err := OpenDataStore(t.config)
  1534. if err != nil {
  1535. return nil, errors.Trace(err)
  1536. }
  1537. defer CloseDataStore()
  1538. value, err := copyBucketValue(datastoreTacticsBucket, []byte(networkID))
  1539. if err != nil {
  1540. return nil, errors.Trace(err)
  1541. }
  1542. return value, nil
  1543. }
  1544. func (t *TacticsStorer) SetSpeedTestSamplesRecord(networkID string, record []byte) error {
  1545. err := OpenDataStore(t.config)
  1546. if err != nil {
  1547. return errors.Trace(err)
  1548. }
  1549. defer CloseDataStore()
  1550. err = setBucketValue(datastoreSpeedTestSamplesBucket, []byte(networkID), record)
  1551. if err != nil {
  1552. return errors.Trace(err)
  1553. }
  1554. return nil
  1555. }
  1556. func (t *TacticsStorer) GetSpeedTestSamplesRecord(networkID string) ([]byte, error) {
  1557. err := OpenDataStore(t.config)
  1558. if err != nil {
  1559. return nil, errors.Trace(err)
  1560. }
  1561. defer CloseDataStore()
  1562. value, err := copyBucketValue(datastoreSpeedTestSamplesBucket, []byte(networkID))
  1563. if err != nil {
  1564. return nil, errors.Trace(err)
  1565. }
  1566. return value, nil
  1567. }
  1568. // GetTacticsStorer creates a TacticsStorer.
  1569. func GetTacticsStorer(config *Config) *TacticsStorer {
  1570. return &TacticsStorer{config: config}
  1571. }
  1572. // GetAffinityServerEntryAndDialParameters fetches the current affinity server
  1573. // entry value and any corresponding dial parameters for the specified network
  1574. // ID. An error is returned when no affinity server is available. The
  1575. // DialParameter output may be nil when a server entry is found but has no
  1576. // dial parameters.
  1577. func GetAffinityServerEntryAndDialParameters(
  1578. networkID string) (protocol.ServerEntryFields, *DialParameters, error) {
  1579. var serverEntryFields protocol.ServerEntryFields
  1580. var dialParams *DialParameters
  1581. err := datastoreView(func(tx *datastoreTx) error {
  1582. keyValues := tx.bucket(datastoreKeyValueBucket)
  1583. serverEntries := tx.bucket(datastoreServerEntriesBucket)
  1584. dialParameters := tx.bucket(datastoreDialParametersBucket)
  1585. affinityServerEntryID := keyValues.get(datastoreAffinityServerEntryIDKey)
  1586. if affinityServerEntryID == nil {
  1587. return errors.TraceNew("no affinity server available")
  1588. }
  1589. serverEntryRecord := serverEntries.get(affinityServerEntryID)
  1590. if serverEntryRecord == nil {
  1591. return errors.TraceNew("affinity server entry not found")
  1592. }
  1593. err := json.Unmarshal(
  1594. serverEntryRecord,
  1595. &serverEntryFields)
  1596. if err != nil {
  1597. return errors.Trace(err)
  1598. }
  1599. dialParamsKey := makeDialParametersKey(
  1600. []byte(serverEntryFields.GetIPAddress()),
  1601. []byte(networkID))
  1602. dialParamsRecord := dialParameters.get(dialParamsKey)
  1603. if dialParamsRecord != nil {
  1604. err := json.Unmarshal(dialParamsRecord, &dialParams)
  1605. if err != nil {
  1606. return errors.Trace(err)
  1607. }
  1608. }
  1609. return nil
  1610. })
  1611. if err != nil {
  1612. return nil, nil, errors.Trace(err)
  1613. }
  1614. return serverEntryFields, dialParams, nil
  1615. }
  1616. func setBucketValue(bucket, key, value []byte) error {
  1617. err := datastoreUpdate(func(tx *datastoreTx) error {
  1618. bucket := tx.bucket(bucket)
  1619. err := bucket.put(key, value)
  1620. if err != nil {
  1621. return errors.Trace(err)
  1622. }
  1623. return nil
  1624. })
  1625. if err != nil {
  1626. return errors.Trace(err)
  1627. }
  1628. return nil
  1629. }
  1630. func getBucketValue(bucket, key []byte, valueCallback func([]byte) error) error {
  1631. err := datastoreView(func(tx *datastoreTx) error {
  1632. bucket := tx.bucket(bucket)
  1633. value := bucket.get(key)
  1634. return valueCallback(value)
  1635. })
  1636. if err != nil {
  1637. return errors.Trace(err)
  1638. }
  1639. return nil
  1640. }
  1641. func deleteBucketValue(bucket, key []byte) error {
  1642. err := datastoreUpdate(func(tx *datastoreTx) error {
  1643. bucket := tx.bucket(bucket)
  1644. return bucket.delete(key)
  1645. })
  1646. if err != nil {
  1647. return errors.Trace(err)
  1648. }
  1649. return nil
  1650. }
  1651. func copyBucketValue(bucket, key []byte) ([]byte, error) {
  1652. var valueCopy []byte
  1653. err := getBucketValue(bucket, key, func(value []byte) error {
  1654. if value != nil {
  1655. // Must make a copy as slice is only valid within transaction.
  1656. valueCopy = make([]byte, len(value))
  1657. copy(valueCopy, value)
  1658. }
  1659. return nil
  1660. })
  1661. return valueCopy, err
  1662. }