bind_test.go 16 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700
  1. package bind
  2. import (
  3. "bytes"
  4. "flag"
  5. "go/ast"
  6. "go/build"
  7. "go/format"
  8. "go/importer"
  9. "go/parser"
  10. "go/token"
  11. "go/types"
  12. "io"
  13. "io/ioutil"
  14. "log"
  15. "os"
  16. "os/exec"
  17. "path"
  18. "path/filepath"
  19. "runtime"
  20. "strings"
  21. "testing"
  22. "golang.org/x/mobile/internal/importers"
  23. "golang.org/x/mobile/internal/importers/java"
  24. "golang.org/x/mobile/internal/importers/objc"
  25. )
  26. func init() {
  27. log.SetFlags(log.Lshortfile)
  28. }
  29. var updateFlag = flag.Bool("update", false, "Update the golden files.")
  30. var tests = []string{
  31. "", // The universe package with the error type.
  32. "testdata/basictypes.go",
  33. "testdata/structs.go",
  34. "testdata/interfaces.go",
  35. "testdata/issue10788.go",
  36. "testdata/issue12328.go",
  37. "testdata/issue12403.go",
  38. "testdata/issue29559.go",
  39. "testdata/keywords.go",
  40. "testdata/try.go",
  41. "testdata/vars.go",
  42. "testdata/ignore.go",
  43. "testdata/doc.go",
  44. "testdata/underscores.go",
  45. }
  46. var javaTests = []string{
  47. "testdata/java.go",
  48. "testdata/classes.go",
  49. }
  50. var objcTests = []string{
  51. "testdata/objc.go",
  52. "testdata/objcw.go",
  53. }
  54. var fset = token.NewFileSet()
  55. func fileRefs(t *testing.T, filename string, pkgPrefix string) *importers.References {
  56. f, err := parser.ParseFile(fset, filename, nil, parser.AllErrors)
  57. if err != nil {
  58. t.Fatalf("%s: %v", filename, err)
  59. }
  60. refs, err := importers.AnalyzeFile(f, pkgPrefix)
  61. if err != nil {
  62. t.Fatalf("%s: %v", filename, err)
  63. }
  64. fakePath := path.Dir(filename)
  65. for i := range refs.Embedders {
  66. refs.Embedders[i].PkgPath = fakePath
  67. }
  68. return refs
  69. }
  70. func typeCheck(t *testing.T, filename string, gopath string) (*types.Package, *ast.File) {
  71. f, err := parser.ParseFile(fset, filename, nil, parser.AllErrors|parser.ParseComments)
  72. if err != nil {
  73. t.Fatalf("%s: %v", filename, err)
  74. }
  75. pkgName := filepath.Base(filename)
  76. pkgName = strings.TrimSuffix(pkgName, ".go")
  77. // typecheck and collect typechecker errors
  78. var conf types.Config
  79. conf.Error = func(err error) {
  80. t.Error(err)
  81. }
  82. if gopath != "" {
  83. conf.Importer = importer.Default()
  84. oldDefault := build.Default
  85. defer func() { build.Default = oldDefault }()
  86. build.Default.GOPATH = gopath
  87. }
  88. pkg, err := conf.Check(pkgName, fset, []*ast.File{f}, nil)
  89. if err != nil {
  90. t.Fatal(err)
  91. }
  92. return pkg, f
  93. }
  94. // diff runs the command "diff a b" and returns its output
  95. func diff(a, b string) string {
  96. var buf bytes.Buffer
  97. var cmd *exec.Cmd
  98. switch runtime.GOOS {
  99. case "plan9":
  100. cmd = exec.Command("/bin/diff", "-c", a, b)
  101. default:
  102. cmd = exec.Command("/usr/bin/diff", "-u", a, b)
  103. }
  104. cmd.Stdout = &buf
  105. cmd.Stderr = &buf
  106. cmd.Run()
  107. return buf.String()
  108. }
  109. func writeTempFile(t *testing.T, name string, contents []byte) string {
  110. f, err := ioutil.TempFile("", name)
  111. if err != nil {
  112. t.Fatal(err)
  113. }
  114. if _, err := f.Write(contents); err != nil {
  115. t.Fatal(err)
  116. }
  117. if err := f.Close(); err != nil {
  118. t.Fatal(err)
  119. }
  120. return f.Name()
  121. }
  122. func TestGenObjc(t *testing.T) {
  123. for _, filename := range tests {
  124. var pkg *types.Package
  125. var file *ast.File
  126. if filename != "" {
  127. pkg, file = typeCheck(t, filename, "")
  128. }
  129. var buf bytes.Buffer
  130. g := &ObjcGen{
  131. Generator: &Generator{
  132. Printer: &Printer{Buf: &buf, IndentEach: []byte("\t")},
  133. Fset: fset,
  134. Files: []*ast.File{file},
  135. Pkg: pkg,
  136. },
  137. }
  138. if pkg != nil {
  139. g.AllPkg = []*types.Package{pkg}
  140. }
  141. g.Init(nil)
  142. testcases := []struct {
  143. suffix string
  144. gen func() error
  145. }{
  146. {
  147. ".objc.h.golden",
  148. g.GenH,
  149. },
  150. {
  151. ".objc.m.golden",
  152. g.GenM,
  153. },
  154. {
  155. ".objc.go.h.golden",
  156. g.GenGoH,
  157. },
  158. }
  159. for _, tc := range testcases {
  160. buf.Reset()
  161. if err := tc.gen(); err != nil {
  162. t.Errorf("%s: %v", filename, err)
  163. continue
  164. }
  165. out := writeTempFile(t, "generated"+tc.suffix, buf.Bytes())
  166. defer os.Remove(out)
  167. var golden string
  168. if filename != "" {
  169. golden = filename[:len(filename)-len(".go")]
  170. } else {
  171. golden = "testdata/universe"
  172. }
  173. golden += tc.suffix
  174. if diffstr := diff(golden, out); diffstr != "" {
  175. t.Errorf("%s: does not match Objective-C golden:\n%s", filename, diffstr)
  176. if *updateFlag {
  177. t.Logf("Updating %s...", golden)
  178. err := exec.Command("/bin/cp", out, golden).Run()
  179. if err != nil {
  180. t.Errorf("Update failed: %s", err)
  181. }
  182. }
  183. }
  184. }
  185. }
  186. }
  187. func genObjcPackages(t *testing.T, dir string, cg *ObjcWrapper) {
  188. pkgBase := filepath.Join(dir, "src", "ObjC")
  189. if err := os.MkdirAll(pkgBase, 0700); err != nil {
  190. t.Fatal(err)
  191. }
  192. for i, jpkg := range cg.Packages() {
  193. pkgDir := filepath.Join(pkgBase, jpkg)
  194. if err := os.MkdirAll(pkgDir, 0700); err != nil {
  195. t.Fatal(err)
  196. }
  197. pkgFile := filepath.Join(pkgDir, "package.go")
  198. cg.Buf.Reset()
  199. cg.GenPackage(i)
  200. if err := ioutil.WriteFile(pkgFile, cg.Buf.Bytes(), 0600); err != nil {
  201. t.Fatal(err)
  202. }
  203. }
  204. cg.Buf.Reset()
  205. cg.GenInterfaces()
  206. clsFile := filepath.Join(pkgBase, "interfaces.go")
  207. if err := ioutil.WriteFile(clsFile, cg.Buf.Bytes(), 0600); err != nil {
  208. t.Fatal(err)
  209. }
  210. gocmd := filepath.Join(runtime.GOROOT(), "bin", "go")
  211. cmd := exec.Command(
  212. gocmd,
  213. "install",
  214. "-pkgdir="+filepath.Join(dir, "pkg", build.Default.GOOS+"_"+build.Default.GOARCH),
  215. "ObjC/...",
  216. )
  217. cmd.Env = append(os.Environ(), "GOPATH="+dir, "GO111MODULE=off")
  218. if out, err := cmd.CombinedOutput(); err != nil {
  219. t.Fatalf("failed to go install the generated ObjC wrappers: %v: %s", err, string(out))
  220. }
  221. }
  222. func genJavaPackages(t *testing.T, dir string, cg *ClassGen) {
  223. buf := cg.Buf
  224. cg.Buf = new(bytes.Buffer)
  225. pkgBase := filepath.Join(dir, "src", "Java")
  226. if err := os.MkdirAll(pkgBase, 0700); err != nil {
  227. t.Fatal(err)
  228. }
  229. for i, jpkg := range cg.Packages() {
  230. pkgDir := filepath.Join(pkgBase, jpkg)
  231. if err := os.MkdirAll(pkgDir, 0700); err != nil {
  232. t.Fatal(err)
  233. }
  234. pkgFile := filepath.Join(pkgDir, "package.go")
  235. cg.Buf.Reset()
  236. cg.GenPackage(i)
  237. if err := ioutil.WriteFile(pkgFile, cg.Buf.Bytes(), 0600); err != nil {
  238. t.Fatal(err)
  239. }
  240. io.Copy(buf, cg.Buf)
  241. }
  242. cg.Buf.Reset()
  243. cg.GenInterfaces()
  244. clsFile := filepath.Join(pkgBase, "interfaces.go")
  245. if err := ioutil.WriteFile(clsFile, cg.Buf.Bytes(), 0600); err != nil {
  246. t.Fatal(err)
  247. }
  248. io.Copy(buf, cg.Buf)
  249. cg.Buf = buf
  250. gocmd := filepath.Join(runtime.GOROOT(), "bin", "go")
  251. cmd := exec.Command(
  252. gocmd,
  253. "install",
  254. "-pkgdir="+filepath.Join(dir, "pkg", build.Default.GOOS+"_"+build.Default.GOARCH),
  255. "Java/...",
  256. )
  257. cmd.Env = append(os.Environ(), "GOPATH="+dir, "GO111MODULE=off")
  258. if out, err := cmd.CombinedOutput(); err != nil {
  259. t.Fatalf("failed to go install the generated Java wrappers: %v: %s", err, string(out))
  260. }
  261. }
  262. func TestGenJava(t *testing.T) {
  263. allTests := tests
  264. if java.IsAvailable() {
  265. allTests = append(append([]string{}, allTests...), javaTests...)
  266. }
  267. for _, filename := range allTests {
  268. var pkg *types.Package
  269. var file *ast.File
  270. var buf bytes.Buffer
  271. var cg *ClassGen
  272. var classes []*java.Class
  273. if filename != "" {
  274. refs := fileRefs(t, filename, "Java/")
  275. imp := &java.Importer{}
  276. var err error
  277. classes, err = imp.Import(refs)
  278. if err != nil {
  279. t.Fatal(err)
  280. }
  281. tmpGopath := ""
  282. if len(classes) > 0 {
  283. tmpGopath, err = ioutil.TempDir(os.TempDir(), "gomobile-bind-test-")
  284. if err != nil {
  285. t.Fatal(err)
  286. }
  287. defer os.RemoveAll(tmpGopath)
  288. cg = &ClassGen{
  289. Printer: &Printer{
  290. IndentEach: []byte("\t"),
  291. Buf: new(bytes.Buffer),
  292. },
  293. }
  294. cg.Init(classes, refs.Embedders)
  295. genJavaPackages(t, tmpGopath, cg)
  296. cg.Buf = &buf
  297. }
  298. pkg, file = typeCheck(t, filename, tmpGopath)
  299. }
  300. g := &JavaGen{
  301. Generator: &Generator{
  302. Printer: &Printer{Buf: &buf, IndentEach: []byte(" ")},
  303. Fset: fset,
  304. Files: []*ast.File{file},
  305. Pkg: pkg,
  306. },
  307. }
  308. if pkg != nil {
  309. g.AllPkg = []*types.Package{pkg}
  310. }
  311. g.Init(classes)
  312. testCases := []struct {
  313. suffix string
  314. gen func() error
  315. }{
  316. {
  317. ".java.golden",
  318. func() error {
  319. for i := range g.ClassNames() {
  320. if err := g.GenClass(i); err != nil {
  321. return err
  322. }
  323. }
  324. return g.GenJava()
  325. },
  326. },
  327. {
  328. ".java.c.golden",
  329. func() error {
  330. if cg != nil {
  331. cg.GenC()
  332. }
  333. return g.GenC()
  334. },
  335. },
  336. {
  337. ".java.h.golden",
  338. func() error {
  339. if cg != nil {
  340. cg.GenH()
  341. }
  342. return g.GenH()
  343. },
  344. },
  345. }
  346. for _, tc := range testCases {
  347. buf.Reset()
  348. if err := tc.gen(); err != nil {
  349. t.Errorf("%s: %v", filename, err)
  350. continue
  351. }
  352. out := writeTempFile(t, "generated"+tc.suffix, buf.Bytes())
  353. defer os.Remove(out)
  354. var golden string
  355. if filename != "" {
  356. golden = filename[:len(filename)-len(".go")]
  357. } else {
  358. golden = "testdata/universe"
  359. }
  360. golden += tc.suffix
  361. if diffstr := diff(golden, out); diffstr != "" {
  362. t.Errorf("%s: does not match Java golden:\n%s", filename, diffstr)
  363. if *updateFlag {
  364. t.Logf("Updating %s...", golden)
  365. if err := exec.Command("/bin/cp", out, golden).Run(); err != nil {
  366. t.Errorf("Update failed: %s", err)
  367. }
  368. }
  369. }
  370. }
  371. }
  372. }
  373. func TestGenGo(t *testing.T) {
  374. for _, filename := range tests {
  375. var buf bytes.Buffer
  376. var pkg *types.Package
  377. if filename != "" {
  378. pkg, _ = typeCheck(t, filename, "")
  379. }
  380. testGenGo(t, filename, &buf, pkg)
  381. }
  382. }
  383. func TestGenGoJavaWrappers(t *testing.T) {
  384. if !java.IsAvailable() {
  385. t.Skipf("java is not available")
  386. }
  387. for _, filename := range javaTests {
  388. var buf bytes.Buffer
  389. refs := fileRefs(t, filename, "Java/")
  390. imp := &java.Importer{}
  391. classes, err := imp.Import(refs)
  392. if err != nil {
  393. t.Fatal(err)
  394. }
  395. tmpGopath, err := ioutil.TempDir(os.TempDir(), "gomobile-bind-test-")
  396. if err != nil {
  397. t.Fatal(err)
  398. }
  399. defer os.RemoveAll(tmpGopath)
  400. cg := &ClassGen{
  401. Printer: &Printer{
  402. IndentEach: []byte("\t"),
  403. Buf: &buf,
  404. },
  405. }
  406. cg.Init(classes, refs.Embedders)
  407. genJavaPackages(t, tmpGopath, cg)
  408. pkg, _ := typeCheck(t, filename, tmpGopath)
  409. cg.GenGo()
  410. testGenGo(t, filename, &buf, pkg)
  411. }
  412. }
  413. func TestGenGoObjcWrappers(t *testing.T) {
  414. if runtime.GOOS != "darwin" {
  415. t.Skipf("can only generate objc wrappers on darwin")
  416. }
  417. for _, filename := range objcTests {
  418. var buf bytes.Buffer
  419. refs := fileRefs(t, filename, "ObjC/")
  420. types, err := objc.Import(refs)
  421. if err != nil {
  422. t.Fatal(err)
  423. }
  424. tmpGopath, err := ioutil.TempDir(os.TempDir(), "gomobile-bind-test-")
  425. if err != nil {
  426. t.Fatal(err)
  427. }
  428. defer os.RemoveAll(tmpGopath)
  429. cg := &ObjcWrapper{
  430. Printer: &Printer{
  431. IndentEach: []byte("\t"),
  432. Buf: &buf,
  433. },
  434. }
  435. var genNames []string
  436. for _, emb := range refs.Embedders {
  437. genNames = append(genNames, emb.Name)
  438. }
  439. cg.Init(types, genNames)
  440. genObjcPackages(t, tmpGopath, cg)
  441. pkg, _ := typeCheck(t, filename, tmpGopath)
  442. cg.GenGo()
  443. testGenGo(t, filename, &buf, pkg)
  444. }
  445. }
  446. func testGenGo(t *testing.T, filename string, buf *bytes.Buffer, pkg *types.Package) {
  447. conf := &GeneratorConfig{
  448. Writer: buf,
  449. Fset: fset,
  450. Pkg: pkg,
  451. }
  452. if pkg != nil {
  453. conf.AllPkg = []*types.Package{pkg}
  454. }
  455. if err := GenGo(conf); err != nil {
  456. t.Errorf("%s: %v", filename, err)
  457. return
  458. }
  459. // TODO(hyangah): let GenGo format the generated go files.
  460. out := writeTempFile(t, "go", gofmt(t, buf.Bytes()))
  461. defer os.Remove(out)
  462. golden := filename
  463. if golden == "" {
  464. golden = "testdata/universe"
  465. }
  466. golden += ".golden"
  467. goldenContents, err := ioutil.ReadFile(golden)
  468. if err != nil {
  469. t.Fatalf("failed to read golden file: %v", err)
  470. }
  471. // format golden file using the current go version's formatting rule.
  472. formattedGolden := writeTempFile(t, "go", gofmt(t, goldenContents))
  473. defer os.Remove(formattedGolden)
  474. if diffstr := diff(formattedGolden, out); diffstr != "" {
  475. t.Errorf("%s: does not match Go golden:\n%s", filename, diffstr)
  476. if *updateFlag {
  477. t.Logf("Updating %s...", golden)
  478. if err := exec.Command("/bin/cp", out, golden).Run(); err != nil {
  479. t.Errorf("Update failed: %s", err)
  480. }
  481. }
  482. }
  483. }
  484. // gofmt formats the collection of Go source files auto-generated by gobind.
  485. func gofmt(t *testing.T, src []byte) []byte {
  486. t.Helper()
  487. buf := &bytes.Buffer{}
  488. mark := []byte(gobindPreamble)
  489. for i, c := range bytes.Split(src, mark) {
  490. if i == 0 {
  491. buf.Write(c)
  492. continue
  493. }
  494. tmp := append(mark, c...)
  495. out, err := format.Source(tmp)
  496. if err != nil {
  497. t.Fatalf("failed to format Go file: error=%v\n----\n%s\n----", err, tmp)
  498. }
  499. if _, err := buf.Write(out); err != nil {
  500. t.Fatalf("failed to write formatted file to buffer: %v", err)
  501. }
  502. }
  503. return buf.Bytes()
  504. }
  505. func TestCustomPrefix(t *testing.T) {
  506. const datafile = "testdata/customprefix.go"
  507. pkg, file := typeCheck(t, datafile, "")
  508. type testCase struct {
  509. golden string
  510. gen func(w io.Writer) error
  511. }
  512. var buf bytes.Buffer
  513. jg := &JavaGen{
  514. JavaPkg: "com.example",
  515. Generator: &Generator{
  516. Printer: &Printer{Buf: &buf, IndentEach: []byte(" ")},
  517. Fset: fset,
  518. AllPkg: []*types.Package{pkg},
  519. Files: []*ast.File{file},
  520. Pkg: pkg,
  521. },
  522. }
  523. jg.Init(nil)
  524. testCases := []testCase{
  525. {
  526. "testdata/customprefix.java.golden",
  527. func(w io.Writer) error {
  528. buf.Reset()
  529. for i := range jg.ClassNames() {
  530. if err := jg.GenClass(i); err != nil {
  531. return err
  532. }
  533. }
  534. if err := jg.GenJava(); err != nil {
  535. return err
  536. }
  537. _, err := io.Copy(w, &buf)
  538. return err
  539. },
  540. },
  541. {
  542. "testdata/customprefix.java.h.golden",
  543. func(w io.Writer) error {
  544. buf.Reset()
  545. if err := jg.GenH(); err != nil {
  546. return err
  547. }
  548. _, err := io.Copy(w, &buf)
  549. return err
  550. },
  551. },
  552. {
  553. "testdata/customprefix.java.c.golden",
  554. func(w io.Writer) error {
  555. buf.Reset()
  556. if err := jg.GenC(); err != nil {
  557. return err
  558. }
  559. _, err := io.Copy(w, &buf)
  560. return err
  561. },
  562. },
  563. }
  564. for _, pref := range []string{"EX", ""} {
  565. og := &ObjcGen{
  566. Prefix: pref,
  567. Generator: &Generator{
  568. Printer: &Printer{Buf: &buf, IndentEach: []byte(" ")},
  569. Fset: fset,
  570. AllPkg: []*types.Package{pkg},
  571. Pkg: pkg,
  572. },
  573. }
  574. og.Init(nil)
  575. testCases = append(testCases, []testCase{
  576. {
  577. "testdata/customprefix" + pref + ".objc.go.h.golden",
  578. func(w io.Writer) error {
  579. buf.Reset()
  580. if err := og.GenGoH(); err != nil {
  581. return err
  582. }
  583. _, err := io.Copy(w, &buf)
  584. return err
  585. },
  586. },
  587. {
  588. "testdata/customprefix" + pref + ".objc.h.golden",
  589. func(w io.Writer) error {
  590. buf.Reset()
  591. if err := og.GenH(); err != nil {
  592. return err
  593. }
  594. _, err := io.Copy(w, &buf)
  595. return err
  596. },
  597. },
  598. {
  599. "testdata/customprefix" + pref + ".objc.m.golden",
  600. func(w io.Writer) error {
  601. buf.Reset()
  602. if err := og.GenM(); err != nil {
  603. return err
  604. }
  605. _, err := io.Copy(w, &buf)
  606. return err
  607. },
  608. },
  609. }...)
  610. }
  611. for _, tc := range testCases {
  612. var buf bytes.Buffer
  613. if err := tc.gen(&buf); err != nil {
  614. t.Errorf("generating %s: %v", tc.golden, err)
  615. continue
  616. }
  617. out := writeTempFile(t, "generated", buf.Bytes())
  618. defer os.Remove(out)
  619. if diffstr := diff(tc.golden, out); diffstr != "" {
  620. t.Errorf("%s: generated file does not match:\b%s", tc.golden, diffstr)
  621. if *updateFlag {
  622. t.Logf("Updating %s...", tc.golden)
  623. err := exec.Command("/bin/cp", out, tc.golden).Run()
  624. if err != nil {
  625. t.Errorf("Update failed: %s", err)
  626. }
  627. }
  628. }
  629. }
  630. }
  631. func TestLowerFirst(t *testing.T) {
  632. testCases := []struct {
  633. in, want string
  634. }{
  635. {"", ""},
  636. {"Hello", "hello"},
  637. {"HelloGopher", "helloGopher"},
  638. {"hello", "hello"},
  639. {"ID", "id"},
  640. {"IDOrName", "idOrName"},
  641. {"ΓειαΣας", "γειαΣας"},
  642. }
  643. for _, tc := range testCases {
  644. if got := lowerFirst(tc.in); got != tc.want {
  645. t.Errorf("lowerFirst(%q) = %q; want %q", tc.in, got, tc.want)
  646. }
  647. }
  648. }
  649. // Test that typeName work for anonymous qualified fields.
  650. func TestSelectorExprTypeName(t *testing.T) {
  651. e, err := parser.ParseExprFrom(fset, "", "struct { bytes.Buffer }", 0)
  652. if err != nil {
  653. t.Fatal(err)
  654. }
  655. ft := e.(*ast.StructType).Fields.List[0].Type
  656. if got, want := typeName(ft), "Buffer"; got != want {
  657. t.Errorf("got: %q; want %q", got, want)
  658. }
  659. }