Rod Hynes 3 лет назад
Родитель
Сommit
feb855fc6b
1 измененных файлов с 5 добавлено и 4 удалено
  1. 5 4
      psiphon/upgradeDownload.go

+ 5 - 4
psiphon/upgradeDownload.go

@@ -46,10 +46,11 @@ import (
 // NOTE: This code does not check that any existing file at config.GetUpgradeDownloadFilename()
 // is actually the version specified in handshakeVersion.
 //
-// when there's already a downloaded upgrade pending. Because the outer client currently
-// handles the authenticated package phase, and because the outer client deletes the
-// intermediate files (including config.GetUpgradeDownloadFilename()), if the outer client
-// does not omit config.GetUpgradeDownloadFilename() then the new version will be downloaded
+// TODO: This logic requires the outer client to *omit* config.UpgradeDownloadURLs, disabling
+// upgrade downloads, when there's already a downloaded upgrade pending. This is because the
+// outer client currently handles the authenticated package phase, and because the outer client
+// deletes the intermediate files (including config.GetUpgradeDownloadFilename()). So if the outer
+// client does not disable upgrade downloads then the new version will be downloaded
 // repeatedly. Implement a new scheme where tunnel core does the authenticated package phase
 // and tracks the the output by version number so that (a) tunnel core knows when it's not
 // necessary to re-download; (b) newer upgrades will be downloaded even when an older