Browse Source

Comment modifyOCSPURL change

- Explain why OCSP request URLs do not need
  to be manually modified to be proxied
mirokuratczyk 6 years ago
parent
commit
f23bb0708a

+ 10 - 0
MobileLibrary/iOS/SampleApps/TunneledWebView/TunneledWebView/AppDelegate.swift

@@ -29,6 +29,16 @@ import PsiphonTunnel
     @objc public lazy var authURLSessionDelegate: OCSPAuthURLSessionDelegate =
         OCSPAuthURLSessionDelegate.init(logger: {print("[AuthURLSessionTaskDelegate]:", $0)},
                                         ocspCache: self.ocspCache,
+                                        // Unlike TunneledWebRequest we do not need to manually
+                                        // update the OCSP request to be proxied through the local
+                                        // HTTP proxy. Since JAHPAuthenticatingHTTPProtocol
+                                        // subclasses and registers itself with NSURLProtocol, all
+                                        // URL requests made manually (using the foundation
+                                        // framework) will be proxied automatically.
+                                        //
+                                        // Since the OCSPCache library makes requests using
+                                        // NSURLSessionDataTask, the OCSP requests will be proxied
+                                        // automatically.
                                         modifyOCSPURL:nil,
                                         session:nil,
                                         timeout:10)