Change BytesTransferred logic

- In iOS Library, to avoid overhead, don't force
  EmitBytesTransferred to true; the user app should
  configure this when required.

- TotalBytesTransferred is always a diagnostic notice.

- BytesTransferred, which is used for user app
  functionality such as the Android traffic graph, is
  never a diagnostic notice (and now won't get included
  in tunnel-core managed rotating files).

MobileLibrary/iOS/PsiphonTunnel/PsiphonTunnel/PsiphonTunnel.m

@@ -582,8 +582,6 @@
     
     config[@"ClientPlatform"] = clientPlatform;
         
-    config[@"EmitBytesTransferred"] = [NSNumber numberWithBool:TRUE];
-
     config[@"DeviceRegion"] = [PsiphonTunnel getDeviceRegion];
     
     config[@"UseIndistinguishableTLS"] = [NSNumber numberWithBool:TRUE];

psiphon/notice.go

@@ -616,40 +616,26 @@ func NoticeClientUpgradeDownloaded(filename string) {
 
 // NoticeBytesTransferred reports how many tunneled bytes have been
 // transferred since the last NoticeBytesTransferred, for the tunnel
-// to the server at ipAddress.
+// to the server at ipAddress. This is not a diagnostic notice: the
+// user app has requested this notice with EmitBytesTransferred for
+// functionality such as traffic display; and this frequent notice
+// is not intended to be included with feedback.
 func NoticeBytesTransferred(ipAddress string, sent, received int64) {
-	if GetEmitDiagnoticNotices() {
-		singletonNoticeLogger.outputNotice(
-			"BytesTransferred", noticeIsDiagnostic,
-			"ipAddress", ipAddress,
-			"sent", sent,
-			"received", received)
-	} else {
-		// This case keeps the EmitBytesTransferred and EmitDiagnosticNotices config options independent
-		singletonNoticeLogger.outputNotice(
-			"BytesTransferred", 0,
-			"sent", sent,
-			"received", received)
-	}
+	singletonNoticeLogger.outputNotice(
+		"BytesTransferred", 0,
+		"sent", sent,
+		"received", received)
 }
 
 // NoticeTotalBytesTransferred reports how many tunneled bytes have been
 // transferred in total up to this point, for the tunnel to the server
-// at ipAddress.
+// at ipAddress. This is a diagnostic notice.
 func NoticeTotalBytesTransferred(ipAddress string, sent, received int64) {
-	if GetEmitDiagnoticNotices() {
-		singletonNoticeLogger.outputNotice(
-			"TotalBytesTransferred", noticeIsDiagnostic,
-			"ipAddress", ipAddress,
-			"sent", sent,
-			"received", received)
-	} else {
-		// This case keeps the EmitBytesTransferred and EmitDiagnosticNotices config options independent
-		singletonNoticeLogger.outputNotice(
-			"TotalBytesTransferred", 0,
-			"sent", sent,
-			"received", received)
-	}
+	singletonNoticeLogger.outputNotice(
+		"TotalBytesTransferred", noticeIsDiagnostic,
+		"ipAddress", ipAddress,
+		"sent", sent,
+		"received", received)
 }
 
 // NoticeLocalProxyError reports a local proxy error message. Repetitive