Browse Source

Document future TODOs

Rod Hynes 3 months ago
parent
commit
a0d6d34b2c
2 changed files with 6 additions and 0 deletions
  1. 3 0
      psiphon/inproxy.go
  2. 3 0
      psiphon/remoteServerList.go

+ 3 - 0
psiphon/inproxy.go

@@ -1310,6 +1310,9 @@ func (brokerDialParams *InproxyBrokerDialParameters) GetMetrics() common.LogFiel
 	}
 	logFields["inproxy_broker_is_reuse"] = isReuse
 
+	// TODO: include tlsConn.GetMetrics tls_did_resume/tls_sent_ticket.
+	// Requires a reference to the InproxyBrokerRoundTripper.
+
 	return logFields
 }
 

+ 3 - 0
psiphon/remoteServerList.go

@@ -474,6 +474,9 @@ func downloadRemoteServerListFile(
 	// MakeDownloadHttpClient will select either a tunneled
 	// or untunneled configuration.
 
+	// TODO: remove TLS cache entries on failure? Wrap tlsCache with
+	// TLSClientSessionCacheWrapper and invoke RemoveCacheEntry.
+
 	payloadSecure := true
 	frontingUseDeviceBinder := true
 	httpClient, tunneled, getParams, err := MakeDownloadHTTPClient(