Просмотр исходного кода

Updated comment

Remove TODO about session key implementation as CustomTLSDial now handles
session key selection using resolved IP addresses.
Amir Khan 9 месяцев назад
Родитель
Сommit
6c8f5bcb1c
1 измененных файлов с 2 добавлено и 6 удалено
  1. 2 6
      psiphon/frontingDialParameters.go

+ 2 - 6
psiphon/frontingDialParameters.go

@@ -406,12 +406,8 @@ func (f *FrontedMeekDialParameters) prepareDialConfigs(
 		ClientTunnelProtocol:     equivilentTunnelProtocol,
 		ClientTunnelProtocol:     equivilentTunnelProtocol,
 		NetworkLatencyMultiplier: f.NetworkLatencyMultiplier,
 		NetworkLatencyMultiplier: f.NetworkLatencyMultiplier,
 		AdditionalHeaders:        config.MeekAdditionalHeaders,
 		AdditionalHeaders:        config.MeekAdditionalHeaders,
-		// TODO: Change hard-coded session key be something like FrontingProviderID + BrokerID.
-		// This is necessary once longer-term TLS caches are added.
-		// The meek dial address, based on the fronting dial address returned by
-		// parameters.FrontingSpecs.SelectParameters has couple of issues. For some providers there's
-		// only a couple or even just one possible value, in other cases there are millions of possible values
-		// and cached values won't be used as often as they ought to be.
+
+		// CustomTLSDial will use the resolved IP address as the session key.
 		TLSClientSessionCache: common.WrapUtlsClientSessionCache(tlsCache, common.TLS_NULL_SESSION_KEY),
 		TLSClientSessionCache: common.WrapUtlsClientSessionCache(tlsCache, common.TLS_NULL_SESSION_KEY),
 	}
 	}