Эх сурвалжийг харах

Refactor: direct assignment to quicConnectionMetrics instead of type assertion

Amir Khan 1 жил өмнө
parent
commit
5a38336004
1 өөрчлөгдсөн 15 нэмэгдсэн , 19 устгасан
  1. 15 19
      psiphon/common/quic/quic.go

+ 15 - 19
psiphon/common/quic/quic.go

@@ -874,29 +874,25 @@ func (t *QUICTransporter) closePacketConn() {
 func (t *QUICTransporter) GetMetrics() common.LogFields {
 	logFields := make(common.LogFields)
 
-	metrics := t.quicConnectionMetrics.Load()
-	if m, ok := metrics.(*quicConnectionMetrics); ok {
+	metrics := t.quicConnectionMetrics.Load().(*quicConnectionMetrics)
 
-		dialEarly := "0"
-		if m.dialEarly {
-			dialEarly = "1"
-		}
-		logFields["quic_dial_early"] = dialEarly
+	dialEarly := "0"
+	if metrics.dialEarly {
+		dialEarly = "1"
+	}
+	logFields["quic_dial_early"] = dialEarly
 
-		quicSentTicket := "0"
-		if m.tlsClientSentTicket {
-			quicSentTicket = "1"
-		}
-		logFields["quic_sent_ticket"] = quicSentTicket
+	quicSentTicket := "0"
+	if metrics.tlsClientSentTicket {
+		quicSentTicket = "1"
+	}
+	logFields["quic_sent_ticket"] = quicSentTicket
 
-		quicDidResume := "0"
-		if m.tlsClientSentTicket {
-			quicDidResume = "1"
-		}
-		logFields["quic_did_resume"] = quicDidResume
-	} else {
-		fmt.Printf("QUICTransporter.GetMetrics: unexpected quicConnectionMetrics type: %T\n", metrics)
+	quicDidResume := "0"
+	if metrics.tlsClientSentTicket {
+		quicDidResume = "1"
 	}
+	logFields["quic_did_resume"] = quicDidResume
 
 	return logFields
 }