Просмотр исходного кода

Fix bug in B2 + passwords containing +

- Remove some outdated code that we don't use any more in v-backup-user 
- Replace escapeshellcmd with quoteshellarg in some random locations
Jaap Marcus 3 лет назад
Родитель
Сommit
f2c6c1bf3d
3 измененных файлов с 5 добавлено и 10 удалено
  1. 1 1
      bin/v-add-backup-host
  2. 1 6
      bin/v-backup-user
  3. 3 3
      web/edit/server/index.php

+ 1 - 1
bin/v-add-backup-host

@@ -230,7 +230,7 @@ if [ $type != 'local' ] && [ $type != 'b2' ]; then
     chmod 660 $HESTIA/conf/$type.backup.conf
 elif [ $type == 'b2' ]; then
     new_timestamp
-    str="BUCKET='$host'\nB2_KEYID='$user'\nB2_KEY='$password'"
+    str="BUCKET='$host'\nB2_KEYID='$user'\nB2_KEY='$raw_password'"
     str="$str\nTIME='$time'\nDATE='$date'"
     echo -e "$str" > $HESTIA/conf/$type.backup.conf
     chmod 660 $HESTIA/conf/$type.backup.conf

+ 1 - 6
bin/v-backup-user

@@ -348,12 +348,7 @@ if [ -n "$WEB_SYSTEM" ] && [ "$WEB" != '*' ]; then
             cp $HESTIA/data/templates/web/$PROXY_SYSTEM/$PROXY.tpl template/$PROXY_SYSTEM/
             cp $HESTIA/data/templates/web/$PROXY_SYSTEM/$PROXY.stpl template/$PROXY_SYSTEM/      
         fi
-        
-        # Backup custom config / backup LE config
-        for sconfig in $(ls $HOMEDIR/$user/conf/web/|grep ".$domain.conf"); do
-            cp $HOMEDIR/$user/conf/web/$sconfig conf/
-        done
-
+    
         # Backup ssl certificates
         if [ "$SSL" = 'yes' ] ; then
             cp $HOMEDIR/$user/conf/web/$domain/ssl/$domain.* conf/

+ 3 - 3
web/edit/server/index.php

@@ -764,7 +764,7 @@ if (!empty($_POST['save'])) {
                 $v_backup_port = quoteshellarg($_POST['v_backup_port']);
                 $v_backup_type = quoteshellarg($_POST['v_backup_type']);
                 $v_backup_username = quoteshellarg($_POST['v_backup_username']);
-                $v_backup_password = escapeshellcmd($_POST['v_backup_password']);
+                $v_backup_password = quoteshellarg($_POST['v_backup_password']);
                 $v_backup_bpath = quoteshellarg($_POST['v_backup_bpath']);
                 exec(HESTIA_CMD."v-add-backup-host ". $v_backup_type ." ". $v_backup_host ." ". $v_backup_username ." ". $v_backup_password ." ". $v_backup_bpath." ".$v_backup_port, $output, $return_var);
                 check_return_code($return_var, $output);
@@ -824,7 +824,7 @@ if (!empty($_POST['save'])) {
                 $v_backup_port = quoteshellarg($_POST['v_backup_port']);
                 $v_backup_type = quoteshellarg($_POST['v_backup_type']);
                 $v_backup_username = quoteshellarg($_POST['v_backup_username']);
-                $v_backup_password = escapeshellcmd($_POST['v_backup_password']);
+                $v_backup_password = quoteshellarg($_POST['v_backup_password']);
                 $v_backup_bpath = quoteshellarg($_POST['v_backup_bpath']);
                 exec(HESTIA_CMD."v-add-backup-host ". $v_backup_type ." ". $v_backup_host ." ". $v_backup_username ." ". $v_backup_password ." ". $v_backup_bpath." ".$v_backup_port, $output, $return_var);
                 check_return_code($return_var, $output);
@@ -881,7 +881,7 @@ if (!empty($_POST['save'])) {
                     $v_backup_port = quoteshellarg($_POST['v_backup_port']);
                     $v_backup_type = quoteshellarg($_POST['v_backup_type']);
                     $v_backup_username = quoteshellarg($_POST['v_backup_username']);
-                    $v_backup_password = escapeshellcmd($_POST['v_backup_password']);
+                    $v_backup_password = quoteshellarg($_POST['v_backup_password']);
                     $v_backup_bpath = quoteshellarg($_POST['v_backup_bpath']);
                     exec(HESTIA_CMD."v-add-backup-host ". $v_backup_type ." ". $v_backup_host ." ". $v_backup_username ." ". $v_backup_password ." ". $v_backup_bpath." ".$v_backup_port, $output, $return_var);
                     check_return_code($return_var, $output);