Browse Source

Adjust let's encrypt validation check for idn domains, thanks to @zanami
This commit closes #779

Raphael Schneeberger 5 years ago
parent
commit
5c3568a4cf
2 changed files with 4 additions and 0 deletions
  1. 1 0
      CHANGELOG.md
  2. 3 0
      bin/v-add-letsencrypt-domain

+ 1 - 0
CHANGELOG.md

@@ -8,6 +8,7 @@ All notable changes to this project will be documented in this file.
 - Disable Apache2 Server Status Module by default.
 - Do not allow to change the password of a non-hestia user. Thanks to Alexandre Zanni!
 - Remove duplicated set-cookie line in default fpm config.
+- Adjust let's encrypt validation check for idn domains, thanks to @zanami!
 
 ## [1.1.1] - 2020-03-24 - Hotfix
 ### Features

+ 3 - 0
bin/v-add-letsencrypt-domain

@@ -134,6 +134,9 @@ fi
 # Check if dns records exist for requested domain/aliases
 if [ "$proto" = "http-01" ]; then
     for identifier in $(echo $domain,$aliases |tr ',' '\n' |sort -u); do
+        if [[ "$identifier" = *[![:ascii:]]* ]]; then
+            identifier=$(idn -t --quiet -a $identifier)
+        fi
         if ! nslookup "${identifier}" > /dev/null 2>&1 ; then
             check_result $E_NOTEXIST "DNS record for $identifier doesn't exist"
         fi